769351 - Clicking on "Source" in the editor breaks templates (by HTML-izing quotes)

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[David Bruant]

Steps:
1) go to https://developer-new.mozilla.org/en-US/docs/JavaScript/Reference/Operators/set
2) click on "edit" (do not change anything)
3) click preview (everything is fine)
4) Click on "Source" to edit the source and not the WYSIWYG way
5) retry preview

Template is broken because of changing quotes
Syntax error at line 20, column 25: Expected "'", ")", "\"", [ \t\n\r;] or [\-.0-9] but "&" found.

   20 | <p>{{js_minversion_note(&quot;1.8.1&quot;, ...

while it should have been

   <p>{{js_minversion_note("1.8.1", ...

And it was until clicking on "Source"

Comment 1

[David Bruant]

Clicking on "Source" again to get the WYSIWYG editor back fixes the template. Good to know :-)

Comment 2

[Les Orchard [:lorchard]]

I think there are actually smarts in kumascript to try to cope with this. Does this actually produce a scripting error on the page?

Comment 3

[David Bruant]

Yes, the one I copy/pasted. Reproduce the steps, you should be able to see the error.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7988ecc276729d80b6dfec9b8f948cbe66362f9f
fix bug 769351 - Preventing entity conversion breaking templates

https://github.com/mozilla/kuma/commit/026343b38dea959cff3b36d7a492e2c5a711b1a1
Merge pull request #325 from darkwing/source-breaks-templates-769351

fix bug 769351 - Preventing entity conversion breaking templates