769388 - Find in page bar overlaps content

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

This was introduced by the patch in bug 739407, which moved the FindInPageBar into gecko_layout. This means that you can't scroll to the bottom of the page while the find bar is open.

Sriram, what was the reasoning for this change?

Comment 1

[Sriram Ramasubramanian [:sriram]]

Aah.. I didn't realize that. I thought it was supposed to be over the content portion and had it with it.
If it was outside, it was over the tabs-ui on tablets -- hence moved it inside the content portion.
I can change the layout.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This moves the Find-in-page toolbar outside, hence it is not over the content. Tested on phone and tablet.

Comment 3

[:Margaret Leibovic]

Comment on attachment 639513 [details] [diff] [review]
Patch

Nice, I'm glad that was an easy change.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8dee2a85c0c9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8dee2a85c0c9

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 639513 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Tabs-Drawer UI.
User impact if declined: Find in page will overlap content.
Testing completed (on m-c, etc.): Landed in m-c on 07/07
Risk to taking this patch (and alternatives if risky): None. Very small layout change.
String or UUID changes made by this patch: None.

Comment 8

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/36e2f0f3e747