769437 - nsCSSFrameConstructor.cpp:2925:59: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

Bug 760848 introduced a build warning in nsCSSFrameConstructor.cpp
{
layout/base/nsCSSFrameConstructor.cpp:2925:59: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
}
by changing the variable "size" from signed to unsigned.

The comparison in question is "size" (unsigned) vs. "kNoSizeSpecified" (signed, w/ value -1) in this line of code:
> 2925     if (((1 == size || 0 == size) || (kNoSizeSpecified  == size)) && (false == multipleSelect)) {
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsCSSFrameConstructor.cpp#2925

It looks like kNoSizeSpecified is _only_ used in this comparison.  If we still need it, we should make it unsigned (and give it the correct (nonnegative) sentinel value), rather than -1.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 2

[Mounir Lamouri (:mounir)]

Comment on attachment 637806 [details] [diff] [review]
Patch v1

Review of attachment 637806 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that change. I was thinking of doing it but haven't find time for it!

r=mounir

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a31fc9052840