Closed Bug 769452 Opened 9 years ago Closed 9 years ago

use NS_FORWARD_NSIACCESSIBLETABLE on accessible tables instead of custom macro

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: tbsaunde, Assigned: vinceyang15)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=C++])

Attachments

(1 file, 1 obsolete file)

8.38 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review
once bug 767705 lands the custom macro is the same as NS_FORWARD_NSIACCESSIBLETABLE(xpcAccessibleTable::) so we should just use that and rm the old macro
the macro is used in accessible/src/generic/ARIAGridAccessible.h accessible/src/html/HTMLTableAccessible.h accessible.src/xul/XULListboxAccessible.h accessible/src/xul/XULTreeGridAccessible.h and is defined at the buttom of accessible/src/xpcom/xpcAccessibleTable.h to be clear I'm talking about the macro named NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETable
Attached patch Patch_v1 (obsolete) — Splinter Review
Attachment #639319 - Flags: review?(trev.saunders)
Comment on attachment 639319 [details] [diff] [review]
Patch_v1

>-#define NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE \
>+#define NS_FORWARD_NSIACCESSIBLETABLE \

you should use the macro from nsIAccessibleTable.h instead of renaming this.
Attachment #639319 - Flags: review?(trev.saunders) → review-
Attached patch Patch_v2Splinter Review
Attachment #639319 - Attachment is obsolete: true
Attachment #641074 - Flags: review?(trev.saunders)
Attachment #641074 - Flags: review?(trev.saunders) → review+
Can anyone help me to set keyword?
Assignee: nobody → vinceyang15
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee398199925

Thanks for the patch! One request - please follow the directions below for any future patches you submit. It makes life easier for those checking in on your behalf. Thanks again!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Xi, we don't resolve bugs until they land on mozilla-central (also, I'm assuming INVALID wasn't the resolution you were going for ;-)...)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Status: REOPENED → ASSIGNED
(In reply to Ryan VanderMeulen from comment #7)
> Xi, we don't resolve bugs until they land on mozilla-central (also, I'm
> assuming INVALID wasn't the resolution you were going for ;-)...)

Sorry about that! and thanks for your advice :-)!
https://hg.mozilla.org/mozilla-central/rev/6ee398199925
Status: ASSIGNED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.