once bug 767705 lands the custom macro is the same as NS_FORWARD_NSIACCESSIBLETABLE(xpcAccessibleTable::) so we should just use that and rm the old macro
the macro is used in accessible/src/generic/ARIAGridAccessible.h accessible/src/html/HTMLTableAccessible.h accessible.src/xul/XULListboxAccessible.h accessible/src/xul/XULTreeGridAccessible.h and is defined at the buttom of accessible/src/xpcom/xpcAccessibleTable.h to be clear I'm talking about the macro named NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETable
Created attachment 639319 [details] [diff] [review] Patch_v1
Attachment #639319 - Flags: review?(trev.saunders)
Comment on attachment 639319 [details] [diff] [review] Patch_v1 >-#define NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE \ >+#define NS_FORWARD_NSIACCESSIBLETABLE \ you should use the macro from nsIAccessibleTable.h instead of renaming this.
Attachment #639319 - Flags: review?(trev.saunders) → review-
Created attachment 641074 [details] [diff] [review] Patch_v2
Attachment #641074 - Flags: review?(trev.saunders) → review+
Can anyone help me to set keyword?
Assignee: nobody → vinceyang15
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee398199925 Thanks for the patch! One request - please follow the directions below for any future patches you submit. It makes life easier for those checking in on your behalf. Thanks again! https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
Xi, we don't resolve bugs until they land on mozilla-central (also, I'm assuming INVALID wasn't the resolution you were going for ;-)...)
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
(In reply to Ryan VanderMeulen from comment #7) > Xi, we don't resolve bugs until they land on mozilla-central (also, I'm > assuming INVALID wasn't the resolution you were going for ;-)...) Sorry about that! and thanks for your advice :-)!
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago → 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.