Last Comment Bug 769452 - use NS_FORWARD_NSIACCESSIBLETABLE on accessible tables instead of custom macro
: use NS_FORWARD_NSIACCESSIBLETABLE on accessible tables instead of custom macro
Status: RESOLVED FIXED
[good first bug][mentor=trev.saunders...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Xi Yang
:
: alexander :surkov
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-06-28 14:11 PDT by Trevor Saunders (:tbsaunde)
Modified: 2012-07-13 05:30 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch_v1 (4.17 KB, patch)
2012-07-05 06:19 PDT, Xi Yang
tbsaunde+mozbugs: review-
Details | Diff | Splinter Review
Patch_v2 (8.38 KB, patch)
2012-07-11 09:05 PDT, Xi Yang
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description Trevor Saunders (:tbsaunde) 2012-06-28 14:11:09 PDT
once bug 767705 lands the custom macro is the same as NS_FORWARD_NSIACCESSIBLETABLE(xpcAccessibleTable::) so we should just use that and rm the old macro
Comment 1 Trevor Saunders (:tbsaunde) 2012-06-28 14:13:47 PDT
the macro is used in accessible/src/generic/ARIAGridAccessible.h accessible/src/html/HTMLTableAccessible.h accessible.src/xul/XULListboxAccessible.h accessible/src/xul/XULTreeGridAccessible.h and is defined at the buttom of accessible/src/xpcom/xpcAccessibleTable.h to be clear I'm talking about the macro named NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETable
Comment 2 Xi Yang 2012-07-05 06:19:56 PDT
Created attachment 639319 [details] [diff] [review]
Patch_v1
Comment 3 Trevor Saunders (:tbsaunde) 2012-07-09 19:18:57 PDT
Comment on attachment 639319 [details] [diff] [review]
Patch_v1

>-#define NS_DECL_OR_FORWARD_NSIACCESSIBLETABLE_WITH_XPCACCESSIBLETABLE \
>+#define NS_FORWARD_NSIACCESSIBLETABLE \

you should use the macro from nsIAccessibleTable.h instead of renaming this.
Comment 4 Xi Yang 2012-07-11 09:05:01 PDT
Created attachment 641074 [details] [diff] [review]
Patch_v2
Comment 5 Xi Yang 2012-07-12 02:06:02 PDT
Can anyone help me to set keyword?
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-12 16:37:44 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/6ee398199925

Thanks for the patch! One request - please follow the directions below for any future patches you submit. It makes life easier for those checking in on your behalf. Thanks again!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-07-12 17:37:42 PDT
Xi, we don't resolve bugs until they land on mozilla-central (also, I'm assuming INVALID wasn't the resolution you were going for ;-)...)
Comment 8 Xi Yang 2012-07-12 18:45:44 PDT
(In reply to Ryan VanderMeulen from comment #7)
> Xi, we don't resolve bugs until they land on mozilla-central (also, I'm
> assuming INVALID wasn't the resolution you were going for ;-)...)

Sorry about that! and thanks for your advice :-)!
Comment 9 Ed Morley [:emorley] 2012-07-13 05:30:52 PDT
https://hg.mozilla.org/mozilla-central/rev/6ee398199925

Note You need to log in before you can comment on or make changes to this bug.