Last Comment Bug 769528 - binscope is currently failing on elm for firefox.exe
: binscope is currently failing on elm for firefox.exe
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: x86_64 Windows 8.1
: -- normal (vote)
: ---
Assigned To: Jim Mathies [:jimm]
:
:
Mentors:
Depends on:
Blocks: 762344
  Show dependency treegraph
 
Reported: 2012-06-28 19:51 PDT by Jim Mathies [:jimm]
Modified: 2014-07-24 11:06 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
nix win line endings in autobinscope.py (5.77 KB, patch)
2012-06-29 05:02 PDT, Jim Mathies [:jimm]
no flags Details | Diff | Splinter Review
dump binscope log on failure (653 bytes, patch)
2012-06-29 05:03 PDT, Jim Mathies [:jimm]
no flags Details | Diff | Splinter Review
failure fix (4.22 KB, patch)
2012-06-29 05:04 PDT, Jim Mathies [:jimm]
no flags Details | Diff | Splinter Review

Description Jim Mathies [:jimm] 2012-06-28 19:51:41 PDT
<targetVersion>16.0a1 Debug</targetVersion>
<targetPath>../../dist/bin/firefox.exe</targetPath>
<issueClass>Binary</issueClass>
<issueType>FunctionPointersCheck</issueType>
<key>FunctionPointersCheck:../../dist/bin/firefox.exe</key>
<testTarget>
<category>Binary</category>
<key>56A230FFBBEC3B21C32553E235401D89519375E8</key>
<type>Target</type>
<logTime>2012-06-28T21:47:36.9474367-05:00</logTime>
</testTarget>
<result>FAIL</result>
<instance>1</instance>

Function pointer _imp___onexit could be overrun by the following buffers: sWorkingDir

we weren't running this on metrofx.exe so it didn't show up until now.
Comment 1 Jim Mathies [:jimm] 2012-06-28 19:54:09 PDT
I'll sort this out in the am.
Comment 2 Jim Mathies [:jimm] 2012-06-29 05:02:20 PDT
Created attachment 637853 [details] [diff] [review]
nix win line endings in autobinscope.py
Comment 3 Jim Mathies [:jimm] 2012-06-29 05:03:14 PDT
Created attachment 637854 [details] [diff] [review]
dump binscope log on failure
Comment 4 Jim Mathies [:jimm] 2012-06-29 05:04:01 PDT
Created attachment 637855 [details] [diff] [review]
failure fix
Comment 5 Brian R. Bondy [:bbondy] 2012-06-29 05:06:02 PDT
Can you push that to elm? If so, is it a good time to pull/update to push a couple unrelated patches?

Note You need to log in before you can comment on or make changes to this bug.