769528 - binscope is currently failing on elm for firefox.exe

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

<targetVersion>16.0a1 Debug</targetVersion>
<targetPath>../../dist/bin/firefox.exe</targetPath>
<issueClass>Binary</issueClass>
<issueType>FunctionPointersCheck</issueType>
<key>FunctionPointersCheck:../../dist/bin/firefox.exe</key>
<testTarget>
<category>Binary</category>
<key>56A230FFBBEC3B21C32553E235401D89519375E8</key>
<type>Target</type>
<logTime>2012-06-28T21:47:36.9474367-05:00</logTime>
</testTarget>
<result>FAIL</result>
<instance>1</instance>

Function pointer _imp___onexit could be overrun by the following buffers: sWorkingDir

we weren't running this on metrofx.exe so it didn't show up until now.

Comment 1

[Jim Mathies [:jimm]]

I'll sort this out in the am.

Comment 2

[Jim Mathies [:jimm]]

Attachment: nix win line endings in autobinscope.py

Comment 3

[Jim Mathies [:jimm]]

Attachment: dump binscope log on failure

Comment 4

[Jim Mathies [:jimm]]

Attachment: failure fix

Comment 5

[Brian R. Bondy [:bbondy]]

Can you push that to elm? If so, is it a good time to pull/update to push a couple unrelated patches?

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/projects/elm/rev/2c8469f7ad58
https://hg.mozilla.org/projects/elm/rev/cc9d99781db7
https://hg.mozilla.org/projects/elm/rev/2c2607e86838