binscope is currently failing on elm for firefox.exe

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
<targetVersion>16.0a1 Debug</targetVersion>
<targetPath>../../dist/bin/firefox.exe</targetPath>
<issueClass>Binary</issueClass>
<issueType>FunctionPointersCheck</issueType>
<key>FunctionPointersCheck:../../dist/bin/firefox.exe</key>
<testTarget>
<category>Binary</category>
<key>56A230FFBBEC3B21C32553E235401D89519375E8</key>
<type>Target</type>
<logTime>2012-06-28T21:47:36.9474367-05:00</logTime>
</testTarget>
<result>FAIL</result>
<instance>1</instance>

Function pointer _imp___onexit could be overrun by the following buffers: sWorkingDir

we weren't running this on metrofx.exe so it didn't show up until now.
(Assignee)

Comment 1

5 years ago
I'll sort this out in the am.
(Assignee)

Comment 2

5 years ago
Created attachment 637853 [details] [diff] [review]
nix win line endings in autobinscope.py
Assignee: nobody → jmathies
(Assignee)

Comment 3

5 years ago
Created attachment 637854 [details] [diff] [review]
dump binscope log on failure
(Assignee)

Comment 4

5 years ago
Created attachment 637855 [details] [diff] [review]
failure fix
Can you push that to elm? If so, is it a good time to pull/update to push a couple unrelated patches?
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/projects/elm/rev/2c8469f7ad58
https://hg.mozilla.org/projects/elm/rev/cc9d99781db7
https://hg.mozilla.org/projects/elm/rev/2c2607e86838
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.