Closed Bug 769529 Opened 10 years ago Closed 10 years ago

Update nsIWebSocket*.idl comments to reflect that we don't always call OnStart

Categories

(Core :: Networking: WebSockets, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

Details

Attachments

(1 file)

We don't always call OnStart, and it's fine IMO.  Websockets are a different animal, and using OnStart only when we've successfully established a connection I think is the right semantic.  But we could wrangle things otherwise if folks feel strongly that making this look more like nsIRequestObserver is important.

Asking biesi for sr, since this is an IDL issue, so I guess might merit sr.  There's no code changes, though, and this is not an IDL that AddOns will ever target, so I'm not sure we really need it.
Attachment #637770 - Flags: superreview?(cbiesinger)
Attachment #637770 - Flags: review?(mcmanus)
Attachment #637770 - Flags: superreview?(cbiesinger) → superreview+
Attachment #637770 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/5c76f0b5100a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Assignee: nobody → jduell.mcbugs
You need to log in before you can comment on or make changes to this bug.