Closed
Bug 769529
Opened 13 years ago
Closed 13 years ago
Update nsIWebSocket*.idl comments to reflect that we don't always call OnStart
Categories
(Core :: Networking: WebSockets, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)
Details
Attachments
(1 file)
|
2.66 KB,
patch
|
mcmanus
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
We don't always call OnStart, and it's fine IMO. Websockets are a different animal, and using OnStart only when we've successfully established a connection I think is the right semantic. But we could wrangle things otherwise if folks feel strongly that making this look more like nsIRequestObserver is important.
Asking biesi for sr, since this is an IDL issue, so I guess might merit sr. There's no code changes, though, and this is not an IDL that AddOns will ever target, so I'm not sure we really need it.
Attachment #637770 -
Flags: superreview?(cbiesinger)
Attachment #637770 -
Flags: review?(mcmanus)
|
||
Updated•13 years ago
|
Attachment #637770 -
Flags: superreview?(cbiesinger) → superreview+
|
||
Updated•13 years ago
|
Attachment #637770 -
Flags: review?(mcmanus) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•13 years ago
|
Assignee: nobody → jduell.mcbugs
You need to log in
before you can comment on or make changes to this bug.
Description
•