Created attachment 637770 [details] [diff] [review] comment-only fix to IDLs We don't always call OnStart, and it's fine IMO. Websockets are a different animal, and using OnStart only when we've successfully established a connection I think is the right semantic. But we could wrangle things otherwise if folks feel strongly that making this look more like nsIRequestObserver is important. Asking biesi for sr, since this is an IDL issue, so I guess might merit sr. There's no code changes, though, and this is not an IDL that AddOns will ever target, so I'm not sure we really need it.
5 years ago