Update nsIWebSocket*.idl comments to reflect that we don't always call OnStart

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jduell, Assigned: jduell)

Tracking

unspecified
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 637770 [details] [diff] [review]
comment-only fix to IDLs

We don't always call OnStart, and it's fine IMO.  Websockets are a different animal, and using OnStart only when we've successfully established a connection I think is the right semantic.  But we could wrangle things otherwise if folks feel strongly that making this look more like nsIRequestObserver is important.

Asking biesi for sr, since this is an IDL issue, so I guess might merit sr.  There's no code changes, though, and this is not an IDL that AddOns will ever target, so I'm not sure we really need it.
Attachment #637770 - Flags: superreview?(cbiesinger)
Attachment #637770 - Flags: review?(mcmanus)
Attachment #637770 - Flags: superreview?(cbiesinger) → superreview+
Attachment #637770 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c76f0b5100a
https://hg.mozilla.org/mozilla-central/rev/5c76f0b5100a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Assignee: nobody → jduell.mcbugs
You need to log in before you can comment on or make changes to this bug.