769571 - Unprefix battery and vibrator APIs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Part 1 - Unprefix Battery API

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Part 2 - Unprefix WebVibrator

Comment 3

[Mounir Lamouri (:mounir)]

This wasn't mentioned in comment 0 but those two APIs are being unprefixed because they are now at CR state and no major change should now happen.

Comment 4

[Justin Lebar (not reading bugmail)]

Comment on attachment 638125 [details] [diff] [review]
Part 2 - Unprefix WebVibrator

r=me, but let's coordinate landing with the Gaia folks so we don't break them too hard.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Thanks for keeping us up to date! We will land https://github.com/mozilla-b2g/gaia/pull/2107 once this has landed.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 638124 [details] [diff] [review]
Part 1 - Unprefix Battery API

You should remove NavigatorBattery and merge it to Navigator.
Per the spec NavigatorBattery is [NoInterfaceObject]

Comment 7

[Mounir Lamouri (:mounir)]

Attachment: Unprefix Battery API

This is changing the behavior of |navigator.battery| when the pref is disabled.
I haven't write test for that because I am not sure whether we will return |null| as I did or if we should return the default values (like if the device was plugged and fully charged). I would tend for the later because that would prevent failures in websites checking if the object is present by doing |'battery' in navigator|.

I will open a follow-up for that.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 639011 [details] [diff] [review]
Unprefix Battery API

I don't think we should do this.

I missed DOM_CLASSINFO_MAP_CONDITIONAL_ENTRY(nsIDOMMozNavigatorBattery,
                                        battery::BatteryManager::HasSupport()) 
earlier, but I think we should rename nsIDOMMozNavigatorBattery to
nsINavigatorBattery so that it doesn't show up in the global scope, yet it
is possible to disable it.

Comment 9

[Mounir Lamouri (:mounir)]

Attachment: Unprefix Battery API

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 639112 [details] [diff] [review]
Unprefix Battery API


> {
>+  if (!battery::BatteryManager::HasSupport()) {
>+    if (mBatteryManager) {
>+      mBatteryManager->Shutdown();
>+      mBatteryManager = nsnull;
>+    }
>+
>+    *aBattery = nsnull;
>+    return NS_OK;
>+  }
>+
Don't make this change.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3626afc51095
https://hg.mozilla.org/mozilla-central/rev/9f088e7bd533