769588 - Port bug 722872 - call the Init method after creating nsITransferable

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #722872 +++

I have already done a minor port here to fix bustage:

http://hg.mozilla.org/comm-central/rev/4e4cd1fb04c3

We need to fix the rest of the instances in mailnews and mail

http://mxr.mozilla.org/comm-central/search?string=nsITransferable&find=mail&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Should be reasonable simple to do, attachment 636714 [details] [diff] [review] has plenty of examples as well.

Comment 1

[:aceman]

I do not understand what should be the argument to .init().

Comment 2

[(no longer active)]

The argument to init() is the load context for the docshell to which the transferable belongs.

Comment 3

[Serge Gautherie (:sgautherie)]

"Found 5 matching lines in 2 files"

Comment 4

[Mark Banner (:standard8)]

Attachment: The fix

Ok, so the best I can work out is that bug 722872 doesn't affect us in the release mode state, but it does affect us in debug.

Strictly speaking this probably therefore isn't required for 16, but I'd feel more comfortable having it in, as a) we won't get people building debug complaining about the assertions and b) if something did happen to change in a security release that really required the init, we'd be protected without having to do extra work.

Comment 5

[Mark Banner (:standard8)]

Oh, and this is basically porting the work directly from bug 722872 to the cases where we use it.

Comment 6

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/181d8e293518

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 666666 [details] [diff] [review]
The fix

[Triage Comment]
Although this isn't super-necessary, I think we should take it anyway as it doesn't really affect us, but does protect us in case something weird gets added later.

Comment 8

[Mark Banner (:standard8)]

Checked in:

https://hg.mozilla.org/releases/comm-aurora/rev/7e3eb66b87d4
https://hg.mozilla.org/releases/comm-beta/rev/b405050a39c2

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Better late than never - I looked at the code, and yes, this looks like the right thing to do.