Closed Bug 769588 Opened 7 years ago Closed 7 years ago

Port bug 722872 - call the Init method after creating nsITransferable


(MailNews Core :: Address Book, defect)

Not set


(thunderbird16+ fixed, thunderbird17 fixed)

Thunderbird 18.0
Tracking Status
thunderbird16 + fixed
thunderbird17 --- fixed


(Reporter: standard8, Assigned: standard8)





(1 file)

+++ This bug was initially created as a clone of Bug #722872 +++

I have already done a minor port here to fix bustage:

We need to fix the rest of the instances in mailnews and mail^[^\0]*%24&hitlimit=&tree=comm-central

Should be reasonable simple to do, attachment 636714 [details] [diff] [review] has plenty of examples as well.
I do not understand what should be the argument to .init().
Blocks: 769603
The argument to init() is the load context for the docshell to which the transferable belongs.
Blocks: 769882
"Found 5 matching lines in 2 files"
Attached patch The fixSplinter Review
Ok, so the best I can work out is that bug 722872 doesn't affect us in the release mode state, but it does affect us in debug.

Strictly speaking this probably therefore isn't required for 16, but I'd feel more comfortable having it in, as a) we won't get people building debug complaining about the assertions and b) if something did happen to change in a security release that really required the init, we'd be protected without having to do extra work.
Assignee: nobody → mbanner
Attachment #666666 - Flags: review?(irving)
Oh, and this is basically porting the work directly from bug 722872 to the cases where we use it.
Attachment #666666 - Flags: review?(irving) → review+
Checked in:
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
Comment on attachment 666666 [details] [diff] [review]
The fix

[Triage Comment]
Although this isn't super-necessary, I think we should take it anyway as it doesn't really affect us, but does protect us in case something weird gets added later.
Attachment #666666 - Flags: approval-comm-beta+
Attachment #666666 - Flags: approval-comm-aurora+
Better late than never - I looked at the code, and yes, this looks like the right thing to do.
You need to log in before you can comment on or make changes to this bug.