769589 - Remove deprecated GetOriginatingURI from nsICookiePermission

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Mike Connor [:mconnor]]

Comment on attachment 637819 [details] [diff] [review]
Patch

r=me.  I'd say r/sr, but there are far more active SRs than cookie peers...

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 637819 [details] [diff] [review]
Patch

whee code removal

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4c7a8c7fc65

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4c7a8c7fc65

Comment 5

[Georg Koppen]

Today I found this ticket while I was looking for a reason why my extension is broken since Aurora. Now, is there an other option for me to get the originating URI of a 3rd party resource from extension land? I did not find any yet (and nobody on #extdev could help me either) but I need it as I am binding some 3rd party stuff to the domain of the originating page.

Comment 6

[Mounir Lamouri (:mounir)]

I'm assuming mozIThirdPartyUtil doesn't really help. Actually, I don't see anything that would obviously replace getOriginatingURI. Christian and Mike, do you have any idea if the deprecation of this method was correct?

BTW, Georg, next time, if you use a deprecated method and can't find a replacement, better to let us know because, usually, deprecation is the first step before removal ;)

Comment 7

[Georg Koppen]

(In reply to Mounir Lamouri (:mounir) from comment #6)
> I'm assuming mozIThirdPartyUtil doesn't really help.
No, unfortunately not.
> Actually, I don't see
> anything that would obviously replace getOriginatingURI. Christian and Mike,
> do you have any idea if the deprecation of this method was correct?
> 
> BTW, Georg, next time, if you use a deprecated method and can't find a
> replacement, better to let us know because, usually, deprecation is the
> first step before removal ;)
I would have done it, no doubt about that. But 
https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsICookiePermission
doesn't say anything about that method being deprecated and, honestly, I am a bit reluctant to check the .idl files always in addition to the documentation on MDN.

Comment 8

[Georg Koppen]

Would a patch (in a new bug) be accepted which adds the getOriginatingURI functionality to ThirdPartyUtil (and exposes it in mozIThirdPartyUtil as well)?

Comment 9

[Peter Eckersley]

Somewhat related: https://bugzilla.mozilla.org/show_bug.cgi?id=878311