[OS.File] Split OS.Constants.Sys and OS.Constants.Path

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: File
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

libxulpath has nothing to do in OS.Constants.Sys, and we intend to add a number of other paths, so let's split OS.Constants.Sys in two: OS.Constants.Sys (which should in time receive the contents of nsSystemInfo) and OS.Constants.Path (which should in time receive the contents of the NS_GetSpecialDirectory).
Created attachment 637904 [details] [diff] [review]
Splitting OS.Constants.Path from OS.Constants.Sys
Assignee: nobody → dteller
Attachment #637904 - Flags: review?(khuey)
Severity: normal → enhancement
OS: Mac OS X → All
Hardware: x86 → All
Created attachment 637905 [details] [diff] [review]
Companion testsuite
Attachment #637905 - Flags: review?(khuey)
Attachment #637904 - Flags: review?(khuey) → review+
Comment on attachment 637905 [details] [diff] [review]
Companion testsuite

Review of attachment 637905 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/tests/worker_constants.js
@@ +38,5 @@
>  function isnot(a, b, description) {
>    send({kind: "isnot", a: a, b:b, description:description});
>  }
>  
> +// Test that OS.Consatnts.Sys.Name is defined

misspelling
Attachment #637905 - Flags: review?(khuey) → review+
Created attachment 638642 [details] [diff] [review]
Splitting OS.Constants.Path from OS.Constants.Sys
Attachment #637904 - Attachment is obsolete: true
Attachment #638642 - Flags: review+
Created attachment 638643 [details] [diff] [review]
Companion testsuite
Attachment #637905 - Attachment is obsolete: true
Attachment #638643 - Flags: review+
Keywords: checkin-needed
Blocks: 750178
https://hg.mozilla.org/integration/mozilla-inbound/rev/df770ecef00a
https://hg.mozilla.org/integration/mozilla-inbound/rev/a198f8d63027
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/df770ecef00a
https://hg.mozilla.org/mozilla-central/rev/a198f8d63027
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 707694
You need to log in before you can comment on or make changes to this bug.