769658 - [OS.File] Split OS.Constants.Sys and OS.Constants.Path

Status: RESOLVED FIXED

(Core :: Networking: File, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

libxulpath has nothing to do in OS.Constants.Sys, and we intend to add a number of other paths, so let's split OS.Constants.Sys in two: OS.Constants.Sys (which should in time receive the contents of nsSystemInfo) and OS.Constants.Path (which should in time receive the contents of the NS_GetSpecialDirectory).

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Splitting OS.Constants.Path from OS.Constants.Sys

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Companion testsuite

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 637905 [details] [diff] [review]
Companion testsuite

Review of attachment 637905 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/tests/worker_constants.js
@@ +38,5 @@
>  function isnot(a, b, description) {
>    send({kind: "isnot", a: a, b:b, description:description});
>  }
>  
> +// Test that OS.Consatnts.Sys.Name is defined

misspelling

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Splitting OS.Constants.Path from OS.Constants.Sys

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Companion testsuite

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df770ecef00a
https://hg.mozilla.org/integration/mozilla-inbound/rev/a198f8d63027

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df770ecef00a
https://hg.mozilla.org/mozilla-central/rev/a198f8d63027