Last Comment Bug 769658 - [OS.File] Split OS.Constants.Sys and OS.Constants.Path
: [OS.File] Split OS.Constants.Sys and OS.Constants.Path
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: File (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla16
Assigned To: David Teller [:Yoric] (please use "needinfo")
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks: 707694 750178
  Show dependency treegraph
 
Reported: 2012-06-29 07:30 PDT by David Teller [:Yoric] (please use "needinfo")
Modified: 2012-12-13 09:51 PST (History)
3 users (show)
ryanvm: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Splitting OS.Constants.Path from OS.Constants.Sys (1.50 KB, patch)
2012-06-29 07:43 PDT, David Teller [:Yoric] (please use "needinfo")
khuey: review+
Details | Diff | Splinter Review
Companion testsuite (1.93 KB, patch)
2012-06-29 07:43 PDT, David Teller [:Yoric] (please use "needinfo")
khuey: review+
Details | Diff | Splinter Review
Splitting OS.Constants.Path from OS.Constants.Sys (1.51 KB, patch)
2012-07-03 03:55 PDT, David Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
Companion testsuite (1.94 KB, patch)
2012-07-03 03:57 PDT, David Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review

Description David Teller [:Yoric] (please use "needinfo") 2012-06-29 07:30:28 PDT
libxulpath has nothing to do in OS.Constants.Sys, and we intend to add a number of other paths, so let's split OS.Constants.Sys in two: OS.Constants.Sys (which should in time receive the contents of nsSystemInfo) and OS.Constants.Path (which should in time receive the contents of the NS_GetSpecialDirectory).
Comment 1 David Teller [:Yoric] (please use "needinfo") 2012-06-29 07:43:08 PDT
Created attachment 637904 [details] [diff] [review]
Splitting OS.Constants.Path from OS.Constants.Sys
Comment 2 David Teller [:Yoric] (please use "needinfo") 2012-06-29 07:43:59 PDT
Created attachment 637905 [details] [diff] [review]
Companion testsuite
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-02 10:25:02 PDT
Comment on attachment 637905 [details] [diff] [review]
Companion testsuite

Review of attachment 637905 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/tests/worker_constants.js
@@ +38,5 @@
>  function isnot(a, b, description) {
>    send({kind: "isnot", a: a, b:b, description:description});
>  }
>  
> +// Test that OS.Consatnts.Sys.Name is defined

misspelling
Comment 4 David Teller [:Yoric] (please use "needinfo") 2012-07-03 03:55:32 PDT
Created attachment 638642 [details] [diff] [review]
Splitting OS.Constants.Path from OS.Constants.Sys
Comment 5 David Teller [:Yoric] (please use "needinfo") 2012-07-03 03:57:09 PDT
Created attachment 638643 [details] [diff] [review]
Companion testsuite

Note You need to log in before you can comment on or make changes to this bug.