The default bug view has changed. See this FAQ.

Unnecessary parens in nsGlobalWindow::GetFuzzTimeMS

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: bsurender)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

There's no need for parentheses around randNum at http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466.

In fact, that if block could go away entirely if it weren't for the randNum == MAX_IDLE_FUZZ_TIME_MS case.
(Assignee)

Comment 1

5 years ago
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #0)
> There's no need for parentheses around randNum at
> http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466.
> 
> In fact, that if block could go away entirely if it weren't for the randNum
> == MAX_IDLE_FUZZ_TIME_MS case.

yeah sorry about the parentheses. it was passed as a function argument before which deref'd to assign the value. after the clean up last night i forgot to remove the parentheses.

block has gone. i just mod it regardless.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Did you check this in?
It's not fixed in the inbound tree I just pulled...

If this is fixed in some other patch, the right thing to do here is mark this bug as depends-on that bug, and mark this as fixed only once that bug is fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
> only once that bug is fixed.

And by that, I mean, only once that bug is checked in.
(Assignee)

Comment 5

5 years ago
(In reply to Justin Lebar [:jlebar] from comment #4)
> > only once that bug is fixed.
> 
> And by that, I mean, only once that bug is checked in.

Got it. Thanks.
https://hg.mozilla.org/mozilla-central/rev/4c42f5fdc769
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.