769722 - Unnecessary parens in nsGlobalWindow::GetFuzzTimeMS

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

There's no need for parentheses around randNum at http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466.

In fact, that if block could go away entirely if it weren't for the randNum == MAX_IDLE_FUZZ_TIME_MS case.

Comment 1

[bsurender]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #0)
> There's no need for parentheses around randNum at
> http://hg.mozilla.org/integration/mozilla-inbound/rev/b405f493e834#l4.466.
> 
> In fact, that if block could go away entirely if it weren't for the randNum
> == MAX_IDLE_FUZZ_TIME_MS case.

yeah sorry about the parentheses. it was passed as a function argument before which deref'd to assign the value. after the clean up last night i forgot to remove the parentheses.

block has gone. i just mod it regardless.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Did you check this in?

Comment 3

[Justin Lebar (not reading bugmail)]

It's not fixed in the inbound tree I just pulled...

If this is fixed in some other patch, the right thing to do here is mark this bug as depends-on that bug, and mark this as fixed only once that bug is fixed.

Comment 4

[Justin Lebar (not reading bugmail)]

> only once that bug is fixed.

And by that, I mean, only once that bug is checked in.

Comment 5

[bsurender]

(In reply to Justin Lebar [:jlebar] from comment #4)
> > only once that bug is fixed.
> 
> And by that, I mean, only once that bug is checked in.

Got it. Thanks.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c42f5fdc769