769735 - Apply Metro styling to dialogs

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Jonathan Wilde [:jwilde]]

The code we pulled from Fennec XUL features dialogs that currently are styled like Android dialogs.  These should be re-styled to fit in with Metro.

Guidelines from Microsoft about this:
http://msdn.microsoft.com/en-us/library/windows/apps/hh738363.aspx
http://msdn.microsoft.com/en-us/library/windows/apps/hh738364.aspx

Comment 1

[Jim Mathies [:jimm]]

Jonathan, do you think we'll need bug 741243, or will we be doing this stuff internally?

Comment 2

[Jonathan Wilde [:jwilde]]

I was thinking we'd just do most of this stuff internally with CSS tweaks, as there's already infrastructure in Fennec-XUL for doing dialogs without producing new windows.

Comment 3

[Jim Mathies [:jimm]]

(In reply to Jonathan Wilde from comment #2)
> I was thinking we'd just do most of this stuff internally with CSS tweaks,
> as there's already infrastructure in Fennec-XUL for doing dialogs without
> producing new windows.

Ok, sounds good. One thing we need to look at is whether we have the right css color attributes to display these elements correctly. If not we can add new ones assuming there's a way to pull the values from the system.

Comment 4

[Jonathan Wilde [:jwilde]]

(In reply to Jim Mathies [:jimm] from comment #3)
> Ok, sounds good. One thing we need to look at is whether we have the right
> css color attributes to display these elements correctly. If not we can add
> new ones assuming there's a way to pull the values from the system.

I was under the impression that Metro color schemes were determined on a per-app basis, rather than a per-theme basis like previous versions of Windows.  Is there a standard pallet to pull from?

Comment 5

[Jim Mathies [:jimm]]

We could test this to see if app dialogs change (for example) background color based on the current color theme. If so then we'll have to pull those from the system dynamically. If these are styled based on the app than we should be ok. I honestly don't know for sure, I just poked around for an app that displays a dialog but couldn't find one.

http://msdn.microsoft.com/en-us/library/windows/apps/hh465304.aspx

This is interesting, while it doesn't answer the color / font question it does raise the issue of dimming the background window. I wonder if we'll need to mimic that as well?

Which fennec dialog were you referring to?

Comment 6

[Jonathan Wilde [:jwilde]]

(In reply to Jim Mathies [:jimm] from comment #5)
> We could test this to see if app dialogs change (for example) background
> color based on the current color theme. If so then we'll have to pull those
> from the system dynamically. If these are styled based on the app than we
> should be ok. I honestly don't know for sure, I just poked around for an app
> that displays a dialog but couldn't find one.
> 
> http://msdn.microsoft.com/en-us/library/windows/apps/hh465304.aspx

Just spent some time digging around Win8.

For dialogs that are for system-wide features, like signing into your Microsoft account, Win8 pulls dialog backgrounds from the user's theme.  

For dialogs that are application-specific, like entering your current location(s) for the Weather app, the application determines the color scheme.

> This is interesting, while it doesn't answer the color / font question it
> does raise the issue of dimming the background window. I wonder if we'll
> need to mimic that as well?

The existing code already handles dimming.  :D

> Which fennec dialog were you referring to?

I'm referring to the overall <xul:dialog> element that's used for "Set Up Sync" on about:home and the application-wide dialogs in browser/metro/base/content/prompt.

Comment 7

[Jim Mathies [:jimm]]

awesome!

Comment 8

[Jonathan Wilde [:jwilde]]

Initial implementation: https://hg.mozilla.org/projects/elm/rev/5e77b5776fe9

Comment 9

[Matt Brubeck (:mbrubeck)]

Resolving bugs in the Firefox for Metro product that are fixed on the elm branch.  Sorry for the bugspam.  Search your email for "bugspam-elm" if you want to find and delete all of these messages at once.