Last Comment Bug 769743 - simplify ScopedCoordinate::slot and fix names
: simplify ScopedCoordinate::slot and fix names
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla16
Assigned To: Luke Wagner [:luke]
: Jason Orendorff [:jorendorff]
Depends on: 770102 778467
  Show dependency treegraph
Reported: 2012-06-29 11:46 PDT by Luke Wagner [:luke]
Modified: 2012-07-28 11:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (36.39 KB, patch)
2012-06-29 11:46 PDT, Luke Wagner [:luke]
dvander: review+
Details | Diff | Splinter Review

Description User image Luke Wagner [:luke] 2012-06-29 11:46:38 PDT
Created attachment 637953 [details] [diff] [review]

ScopeCoordinate::slot isn't really the scope object slot, it's some sort of abstract index.  It should be the slot (esp. with bug 767013).

This patch also simplifies the conversions between frame-relative indices and scope-object-relative indices.  The comment in jsscript.h should explain.

Flagging dvander for review since this should require some minor tweaks in IM when this merges.
Comment 1 User image Luke Wagner [:luke] 2012-06-29 16:28:53 PDT
Thanks for the quick review!
Comment 2 User image Phil Ringnalda (:philor) 2012-06-29 19:10:31 PDT
Backed out in - it was a little bit short of actually compiling.
Comment 3 User image Phil Ringnalda (:philor) 2012-06-29 19:11:38 PDT
s/compiling/compiling for 32-bit/
Comment 4 User image Luke Wagner [:luke] 2012-06-29 19:30:35 PDT
Arg; the cursed JS_STATIC_ASSERT(sizeof(JSScript) % sizeof(Value) == 0).
Comment 5 User image Jeff Walden [:Waldo] (remove +bmo to email) 2012-06-30 00:31:25 PDT
Now the no-methodjit shell builds are burning (#winning):
Comment 6 User image Ryan VanderMeulen [:RyanVM] 2012-06-30 12:42:43 PDT
Comment 7 User image Ryan VanderMeulen [:RyanVM] 2012-07-02 19:01:08 PDT

Note You need to log in before you can comment on or make changes to this bug.