769743 - simplify ScopedCoordinate::slot and fix names

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

ScopeCoordinate::slot isn't really the scope object slot, it's some sort of abstract index.  It should be the slot (esp. with bug 767013).

This patch also simplifies the conversions between frame-relative indices and scope-object-relative indices.  The comment in jsscript.h should explain.

Flagging dvander for review since this should require some minor tweaks in IM when this merges.

Comment 1

[Luke Wagner [:luke]]

Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8bab55ac425

Comment 2

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/df25da024956 - it was a little bit short of actually compiling.

Comment 3

[Phil Ringnalda (:philor)]

s/compiling/compiling for 32-bit/

Comment 4

[Luke Wagner [:luke]]

Arg; the cursed JS_STATIC_ASSERT(sizeof(JSScript) % sizeof(Value) == 0).

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9f7fb55226

Comment 5

[Jeff Walden [:Waldo]]

Now the no-methodjit shell builds are burning (#winning):

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&noignore=1&jobname=spidermonkey

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0d9f7fb55226

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3b86df322556