simplify ScopedCoordinate::slot and fix names

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 637953 [details] [diff] [review]
patch

ScopeCoordinate::slot isn't really the scope object slot, it's some sort of abstract index.  It should be the slot (esp. with bug 767013).

This patch also simplifies the conversions between frame-relative indices and scope-object-relative indices.  The comment in jsscript.h should explain.

Flagging dvander for review since this should require some minor tweaks in IM when this merges.
Attachment #637953 - Flags: review?(dvander)
Attachment #637953 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

5 years ago
Thanks for the quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8bab55ac425
Target Milestone: --- → mozilla16
Whiteboard: [js:t]
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/df25da024956 - it was a little bit short of actually compiling.
s/compiling/compiling for 32-bit/
(Assignee)

Comment 4

5 years ago
Arg; the cursed JS_STATIC_ASSERT(sizeof(JSScript) % sizeof(Value) == 0).

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d9f7fb55226
Now the no-methodjit shell builds are burning (#winning):

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&noignore=1&jobname=spidermonkey
https://hg.mozilla.org/mozilla-central/rev/0d9f7fb55226
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 770102
https://hg.mozilla.org/mozilla-central/rev/3b86df322556

Updated

5 years ago
Depends on: 778467
You need to log in before you can comment on or make changes to this bug.