Last Comment Bug 769782 - remove synchronous DNS resolution in network tests
: remove synchronous DNS resolution in network tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: DNS (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Josh Aas
:
: Patrick McManus [:mcmanus]
Mentors:
Depends on:
Blocks: 766973
  Show dependency treegraph
 
Reported: 2012-06-29 13:13 PDT by Josh Aas
Modified: 2012-07-10 20:31 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (4.03 KB, patch)
2012-06-29 13:16 PDT, Josh Aas
mcmanus: review+
Details | Diff | Splinter Review

Description Josh Aas 2012-06-29 13:13:43 PDT

    
Comment 1 Josh Aas 2012-06-29 13:16:57 PDT
Created attachment 637984 [details] [diff] [review]
fix v1.0
Comment 2 Patrick McManus [:mcmanus] 2012-07-10 08:50:06 PDT
Comment on attachment 637984 [details] [diff] [review]
fix v1.0

Review of attachment 637984 [details] [diff] [review]:
-----------------------------------------------------------------

sorry about the vacation induced delay.. why break up into two tests?
Comment 3 Josh Aas 2012-07-10 08:51:50 PDT
It was just annoyingly complicated to run two async tests serially and keep track of completion. I actually had it written and working but the code was harder to read.
Comment 5 Josh Aas 2012-07-10 15:23:56 PDT
pushed to mozilla-inbound

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0ca33f85d5ce
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-10 20:31:39 PDT
https://hg.mozilla.org/mozilla-central/rev/0ca33f85d5ce

Note You need to log in before you can comment on or make changes to this bug.