remove synchronous DNS resolution in network tests

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: DNS
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 637984 [details] [diff] [review]
fix v1.0
Attachment #637984 - Flags: review?(sworkman)
(Assignee)

Updated

5 years ago
Attachment #637984 - Flags: review?(sworkman) → review?(mcmanus)
Comment on attachment 637984 [details] [diff] [review]
fix v1.0

Review of attachment 637984 [details] [diff] [review]:
-----------------------------------------------------------------

sorry about the vacation induced delay.. why break up into two tests?
Attachment #637984 - Flags: review?(mcmanus) → review+
(Assignee)

Comment 3

5 years ago
It was just annoyingly complicated to run two async tests serially and keep track of completion. I actually had it written and working but the code was harder to read.
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=aeb802c4f7ef
(Assignee)

Comment 5

5 years ago
pushed to mozilla-inbound

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0ca33f85d5ce
https://hg.mozilla.org/mozilla-central/rev/0ca33f85d5ce
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.