Closed
Bug 769782
Opened 13 years ago
Closed 13 years ago
remove synchronous DNS resolution in network tests
Categories
(Core :: Networking: DNS, defect)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jaas, Assigned: jaas)
References
Details
Attachments
(1 file)
|
4.03 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #637984 -
Flags: review?(sworkman)
Attachment #637984 -
Flags: review?(sworkman) → review?(mcmanus)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 637984 [details] [diff] [review]
fix v1.0
Review of attachment 637984 [details] [diff] [review]:
-----------------------------------------------------------------
sorry about the vacation induced delay.. why break up into two tests?
Attachment #637984 -
Flags: review?(mcmanus) → review+
It was just annoyingly complicated to run two async tests serially and keep track of completion. I actually had it written and working but the code was harder to read.
pushed to mozilla-inbound
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0ca33f85d5ce
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•