Closed Bug 769840 Opened 8 years ago Closed 8 years ago

Change the maximum number of apps allowed to be installed in firefox for android to some larger number

Categories

(Firefox for Android :: Web Apps (PWAs), defect, P1)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 16
Tracking Status
firefox16 --- verified

People

(Reporter: jsmith, Assigned: wesj)

References

Details

(Whiteboard: [blocking-webrtandroid1+])

Attachments

(1 file)

Currently we only support installation of ten apps on firefox for android, given that the number is hardcoded in the android manifest. Ten is probably too small of a number, so let's increase this number. Ragavan or Jen might have an idea of a good max to shoot for or we could quickly call this out in the triage.
QA Contact: aaron.train
Where is this defined?
100 is the magic number.
Priority: -- → P1
Attached patch PatchSplinter Review
Bump the max
Assignee: nobody → wjohnston
Attachment #641255 - Flags: review?(mark.finkle)
Comment on attachment 641255 [details] [diff] [review]
Patch

># HG changeset patch
># Parent 0458bd6e5080a67ef9bae165e1de1c5667607960
>
>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in
>--- a/mobile/android/base/Makefile.in
>+++ b/mobile/android/base/Makefile.in
>@@ -949,17 +949,17 @@ android-preqs = \
> 
> $(android-tgts): % : %.in $(android-preqs)
> 	$(PYTHON) $(topsrcdir)/config/Preprocessor.py \
>              $(AUTOMATION_PPARGS) -DOBJDIR="`pwd`" $(DEFINES) $(ACDEFINES) $< > $@
> 
> # Add a predefined number of WebApp<num> classes to the WebApps class.
> # These are used so that each webapp can launch in its own process
> # Keep this number in sync with the max web apps in WebAppAllocator.java
>-NUM_WEB_APPS=10
>+NUM_WEB_APPS=100
> WebAppManifestFragment.xml.in: WebAppManifestFragment.xml.frag
> 	@rm -f $@
> 	@for n in `$(PYTHON) -c "for x in range($(NUM_WEB_APPS)): print x"`; do \
> 		cat $< | sed s,@APPNUM@,$$n,g >> $@ ; \
> 	done
> 
> WebAppsFragments.java: WebAppsFragment.java.frag
> 	@rm -f $@
>diff --git a/mobile/android/base/WebAppAllocator.java b/mobile/android/base/WebAppAllocator.java
>--- a/mobile/android/base/WebAppAllocator.java
>+++ b/mobile/android/base/WebAppAllocator.java
>@@ -9,17 +9,17 @@ import android.util.Log;
> import android.content.Context;
> import android.content.SharedPreferences;
> 
> import org.json.JSONObject;
> import org.json.JSONException;
> 
> public class WebAppAllocator {
>     // The number of WebApp# and WEBAPP# activites/apps/intents
>-    private final static int MAX_WEB_APPS = 10;
>+    private final static int MAX_WEB_APPS = 100;
> 
>     protected static GeckoApp sContext = null;
>     protected static WebAppAllocator sInstance = null;
>     public static WebAppAllocator getInstance() {
>         return getInstance(GeckoApp.mAppContext);
>     }
> 
>     public static synchronized WebAppAllocator getInstance(Context cx) {
Attachment #641255 - Flags: review?(mark.finkle) → review+
Whiteboard: [qa+]
https://hg.mozilla.org/mozilla-central/rev/7dddcb67fbac
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified Fixed on M-C (Nightly 07/15)

+ Able to install more than 10 apps
Status: RESOLVED → VERIFIED
Whiteboard: [qa+]
Target Milestone: --- → Firefox 16
Whiteboard: [blocking-webrtandroid1+]
You need to log in before you can comment on or make changes to this bug.