769840 - Change the maximum number of apps allowed to be installed in firefox for android to some larger number

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Jason Smith [:jsmith]]

Currently we only support installation of ten apps on firefox for android, given that the number is hardcoded in the android manifest. Ten is probably too small of a number, so let's increase this number. Ragavan or Jen might have an idea of a good max to shoot for or we could quickly call this out in the triage.

Comment 1

[Aaron Train [:aaronmt]]

Where is this defined?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Where is this defined?

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/Makefile.in#1062
and
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/WebAppAllocator.java#17

Comment 3

[Jason Smith [:jsmith]]

100 is the magic number.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Bump the max

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 641255 [details] [diff] [review]
Patch

># HG changeset patch
># Parent 0458bd6e5080a67ef9bae165e1de1c5667607960
>
>diff --git a/mobile/android/base/Makefile.in b/mobile/android/base/Makefile.in
>--- a/mobile/android/base/Makefile.in
>+++ b/mobile/android/base/Makefile.in
>@@ -949,17 +949,17 @@ android-preqs = \
> 
> $(android-tgts): % : %.in $(android-preqs)
> 	$(PYTHON) $(topsrcdir)/config/Preprocessor.py \
>              $(AUTOMATION_PPARGS) -DOBJDIR="`pwd`" $(DEFINES) $(ACDEFINES) $< > $@
> 
> # Add a predefined number of WebApp<num> classes to the WebApps class.
> # These are used so that each webapp can launch in its own process
> # Keep this number in sync with the max web apps in WebAppAllocator.java
>-NUM_WEB_APPS=10
>+NUM_WEB_APPS=100
> WebAppManifestFragment.xml.in: WebAppManifestFragment.xml.frag
> 	@rm -f $@
> 	@for n in `$(PYTHON) -c "for x in range($(NUM_WEB_APPS)): print x"`; do \
> 		cat $< | sed s,@APPNUM@,$$n,g >> $@ ; \
> 	done
> 
> WebAppsFragments.java: WebAppsFragment.java.frag
> 	@rm -f $@
>diff --git a/mobile/android/base/WebAppAllocator.java b/mobile/android/base/WebAppAllocator.java
>--- a/mobile/android/base/WebAppAllocator.java
>+++ b/mobile/android/base/WebAppAllocator.java
>@@ -9,17 +9,17 @@ import android.util.Log;
> import android.content.Context;
> import android.content.SharedPreferences;
> 
> import org.json.JSONObject;
> import org.json.JSONException;
> 
> public class WebAppAllocator {
>     // The number of WebApp# and WEBAPP# activites/apps/intents
>-    private final static int MAX_WEB_APPS = 10;
>+    private final static int MAX_WEB_APPS = 100;
> 
>     protected static GeckoApp sContext = null;
>     protected static WebAppAllocator sInstance = null;
>     public static WebAppAllocator getInstance() {
>         return getInstance(GeckoApp.mAppContext);
>     }
> 
>     public static synchronized WebAppAllocator getInstance(Context cx) {

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7dddcb67fbac

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7dddcb67fbac

Comment 8

[Aaron Train [:aaronmt]]

Verified Fixed on M-C (Nightly 07/15)

+ Able to install more than 10 apps