Closed
Bug 769849
Opened 13 years ago
Closed 12 years ago
[mozinfo] use in-tree simplejson vs rolling our own (again)
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(1 file)
|
731 bytes,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/config/writemozinfo.py#70 says
# replace this with the json module when Python >= 2.6 is a requirement.
However, we already have simplejson in the tree:
http://mxr.mozilla.org/mozilla-central/source/other-licenses/simplejson-2.1.1/
We should make use of it
|
Reporter | |
Comment 1•12 years ago
|
||
So the first step here is removing the crazy code from mozinfo.
|
|
Reporter | |
Updated•12 years ago
|
Summary: use in-tree simplejson vs rolling our own (again) → [mozinfo/writemozinfo] use in-tree simplejson vs rolling our own (again)
|
|
Reporter | |
Comment 2•12 years ago
|
||
Attachment #700719 -
Flags: review?(wlachance)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 700719 [details] [diff] [review]
just remove it
LGTM assuming this doesn't break anything. :)
Attachment #700719 -
Flags: review?(wlachance) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
It won't break anything github-side and since the CLI is never used m-c side we should be good there too. I also want to unfutz mozilla-central soon, which is the end goal of my current journey into triage
|
|
Reporter | |
Comment 5•12 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/cb071c1b1569fbaf137ed97824b90b5cfd0067d0
Still have to correct what we do on m-c to really resolve this bug
|
|
Reporter | |
Comment 6•12 years ago
|
||
going to call this just the mozinfo piece due to the separate filing of bug 845620. Done.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Summary: [mozinfo/writemozinfo] use in-tree simplejson vs rolling our own (again) → [mozinfo] use in-tree simplejson vs rolling our own (again)
You need to log in
before you can comment on or make changes to this bug.
Description
•