copyStringToClipboard Optional parameters should go at the end, also this will make it backward compatible for version bumped extensions.

RESOLVED FIXED in mozilla16

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Ehsan)

Tracking

({addon-compat})

Trunk
mozilla16
addon-compat
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
From 722872 Comment 26:
> (In reply to Philip Chee from comment #21)
>> > -  void copyStringToClipboard(in AString aString, in long aClipboardID);
>> > +  void copyStringToClipboard(in AString aString, [optional] in nsIDOMDocument aDoc, in long aClipboardID);
>> 
>> Won't it be better to put the |[optional] in nsIDOMDocument aDoc| at the end
>> to make this method backward compatible for extensions that need to work in
>> more than one version of Firefox/Thunderbird/etc?
> 
> Please file a bug on that and assign it to me.  Thanks!

Also from Comment 23:
> Are you even allowed a non-trailing optional parameter?
Created attachment 638201 [details] [diff] [review]
Patch (v1)
Attachment #638201 - Flags: review?(roc)
Attachment #638201 - Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/108984fa0a89
Target Milestone: --- → mozilla16

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/108984fa0a89
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.