Last Comment Bug 769881 - copyStringToClipboard Optional parameters should go at the end, also this will make it backward compatible for version bumped extensions.
: copyStringToClipboard Optional parameters should go at the end, also this wil...
Status: RESOLVED FIXED
: addon-compat
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks: 722872
  Show dependency treegraph
 
Reported: 2012-06-29 20:25 PDT by Philip Chee
Modified: 2012-07-02 18:42 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (6.39 KB, patch)
2012-07-01 11:18 PDT, :Ehsan Akhgari
roc: review+
Details | Diff | Splinter Review

Description Philip Chee 2012-06-29 20:25:58 PDT
From 722872 Comment 26:
> (In reply to Philip Chee from comment #21)
>> > -  void copyStringToClipboard(in AString aString, in long aClipboardID);
>> > +  void copyStringToClipboard(in AString aString, [optional] in nsIDOMDocument aDoc, in long aClipboardID);
>> 
>> Won't it be better to put the |[optional] in nsIDOMDocument aDoc| at the end
>> to make this method backward compatible for extensions that need to work in
>> more than one version of Firefox/Thunderbird/etc?
> 
> Please file a bug on that and assign it to me.  Thanks!

Also from Comment 23:
> Are you even allowed a non-trailing optional parameter?
Comment 1 :Ehsan Akhgari 2012-07-01 11:18:45 PDT
Created attachment 638201 [details] [diff] [review]
Patch (v1)

Note You need to log in before you can comment on or make changes to this bug.