If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Doorhanger popup on Twitter Mobile closes too quickly

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: micmon, Assigned: Margaret)

Tracking

15 Branch
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified, firefox16 verified, firefox17 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
On the Twitter mobile pages (for example: https://mobile.twitter.com/ChainsDD), a doorhanger (location information?) is shown for a fraction of a second but it auto-closes right away so it cannot be interacted with.
Margaret - Do we need to play with the timeout of the doorhanger for this?
(Assignee)

Comment 2

5 years ago
I added some logging to investigate, and the issue here is that we're getting two Content:LocationChange events for https://mobile.twitter.com/*. I'm not sure what Twitter is doing to cause this. As a workaround, we could make sure to only call updatePopups() if the URI hasn't changed, but that would be a change that would apply to all notifications. That would also mean that the notification would reappear if you reload a page if you just tapped outside to dismiss it, but most notifications would reappear in that case anyway.

I'm hesitant to add a timeout for the geolocation notification, since that can lead to bugs where the notification from a previous page appears on a new page.
(Assignee)

Comment 3

5 years ago
(In reply to Margaret Leibovic [:margaret] from comment #2)
> I added some logging to investigate, and the issue here is that we're
> getting two Content:LocationChange events for https://mobile.twitter.com/*.
> I'm not sure what Twitter is doing to cause this. As a workaround, we could
> make sure to only call updatePopups() if the URI hasn't changed, but that
> would be a change that would apply to all notifications. That would also
> mean that the notification would reappear if you reload a page if you just
> tapped outside to dismiss it, but most notifications would reappear in that
> case anyway.

Actually, after thinking about this more, if you've dismissed a popup, then reloaded the page, we wouldn't call updatePopups(), so you couldn't get the popup back if you wanted it, and that would be unexpected.

It seems like what we really want is to keep the popup showing if it's already showing *and* the URI hasn't changed.
(Assignee)

Comment 4

5 years ago
Created attachment 638819 [details] [diff] [review]
patch

This patch makes it so that we'll only try to remove doorhangers on location change if the doorhanger popup is hidden or if the tab's URL is actually changing.
Assignee: nobody → margaret.leibovic
Attachment #638819 - Flags: review?(mark.finkle)
Comment on attachment 638819 [details] [diff] [review]
patch

Makes sense
Attachment #638819 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a48058e9b9b3
Target Milestone: --- → Firefox 16
(Assignee)

Comment 7

5 years ago
Comment on attachment 638819 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): n/a
User impact if declined: if a site does some sort of scripted reload, doorhanger notifications can disappear before the user can address them; this happens on Twitter
Testing completed (on m-c, etc.): just landed on m-c
Risk to taking this patch (and alternatives if risky): low-risk extra check before deciding to remove doorhangers
String or UUID changes made by this patch: n/a
Attachment #638819 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 8

5 years ago
(In reply to Margaret Leibovic [:margaret] from comment #7)

> Testing completed (on m-c, etc.): just landed on m-c

Er, I mean inbound.
https://hg.mozilla.org/mozilla-central/rev/a48058e9b9b3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Attachment #638819 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/1eb8ae1b3c1a
status-firefox15: --- → fixed
status-firefox16: --- → fixed

Updated

5 years ago
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified
You need to log in before you can comment on or make changes to this bug.