Closed Bug 769908 Opened 10 years ago Closed 10 years ago

Switch DIR_INSTALL to INSTALL

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: rain1, Assigned: SeanDer13)

References

Details

(Whiteboard: [good first bug][mentor=sid0][lang=shell])

Attachments

(1 file, 1 obsolete file)

DIR_INSTALL is going to be obsolete once bug 757252 is fixed. We should get rid of it.

This should be simple enough to do with a find and replace. We should fix this in both mozilla-central and comm-central.
Depends on: 757252
Whiteboard: [good first bug][mentor=sid0] → [good first bug][mentor=sid0][lang=sh]
Whiteboard: [good first bug][mentor=sid0][lang=sh] → [good first bug][mentor=sid0][lang=shell]
(In reply to Siddharth Agarwal [:sid0] from comment #0)
> DIR_INSTALL is going to be obsolete once bug 757252 is fixed. We should get
> rid of it.
> 
> This should be simple enough to do with a find and replace. We should fix
> this in both mozilla-central and comm-central.

Siddharth I am new to Mozilla, and came here through the bugs with mentors program. Is this bug still a good one to help and close? I am just gonna grep around and find the DIR_INSTALL string and change it where need be.

After thats all done just attach a unified patch from hg?
That would be good, but what would be even better would be if you converted single-line commands to install_cmd. See bug 680636.
Attached patch Fix for bug 769908 (obsolete) — Splinter Review
Attachment #640672 - Flags: review?(ted.mielczarek)
Comment on attachment 640672 [details] [diff] [review]
Fix for bug 769908

Review of attachment 640672 [details] [diff] [review]:
-----------------------------------------------------------------

This looks just about good, but you missed a spot:
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/ipc/Makefile.in#48
Attachment #640672 - Flags: review?(ted.mielczarek) → review-
Thanks for the patch! If you fix that one issue we should be able to get it landed.
Assignee: nobody → SeanDer13
Attached patch 2nd PatchSplinter Review
Ted here is the new patch with the line I missed. Thanks!
Attachment #640672 - Attachment is obsolete: true
Attachment #644430 - Flags: review?(ted.mielczarek)
Comment on attachment 644430 [details] [diff] [review]
2nd Patch

Review of attachment 644430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #644430 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/687711cf6f30

Thanks for the patch, Sean! One request - to make life easier for those checking in on your behalf, please follow the directions at the link below for any future patches you submit to make sure that all the necessary commit information is present. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/687711cf6f30
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Pushed a bustage fix from trailing whitespace after a backslash: http://hg.mozilla.org/mozilla-central/rev/cb0b3e605cf1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.