TestTXMgr.cpp should use fail() from TestHarness.h

RESOLVED FIXED in mozilla16

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ekanan Ketunuti)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The test at <http://mxr.mozilla.org/mozilla-central/source/editor/txmgr/tests/TestTXMgr.cpp> should be changed to use the fail() function defined in <http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/TestHarness.h>.

In particular, every line reading

  printf("ERROR: ...

should instead read

  fail("...
(Assignee)

Updated

5 years ago
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 638122 [details] [diff] [review]
v1
Attachment #638122 - Flags: review?(Ms2ger)
(Reporter)

Comment 2

5 years ago
Comment on attachment 638122 [details] [diff] [review]
v1

Review of attachment 638122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Ehsan, can you review?
Attachment #638122 - Flags: review?(ehsan)
Attachment #638122 - Flags: review?(Ms2ger)
Attachment #638122 - Flags: feedback+
Comment on attachment 638122 [details] [diff] [review]
v1

Looks great, thanks!
Attachment #638122 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a3efc841a24f
Target Milestone: --- → mozilla16
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/mozilla-central/rev/a3efc841a24f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.