Closed
Bug 769913
Opened 13 years ago
Closed 13 years ago
TestTXMgr.cpp should use fail() from TestHarness.h
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: ananuti)
Details
(Whiteboard: [good first bug][mentor=Ms2ger][lang=c++])
Attachments
(1 file)
|
129.97 KB,
patch
|
ehsan.akhgari
:
review+
Ms2ger
:
feedback+
|
Details | Diff | Splinter Review |
The test at <http://mxr.mozilla.org/mozilla-central/source/editor/txmgr/tests/TestTXMgr.cpp> should be changed to use the fail() function defined in <http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/TestHarness.h>.
In particular, every line reading
printf("ERROR: ...
should instead read
fail("...
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #638122 -
Flags: review?(Ms2ger)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 638122 [details] [diff] [review]
v1
Review of attachment 638122 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Ehsan, can you review?
Attachment #638122 -
Flags: review?(ehsan)
Attachment #638122 -
Flags: review?(Ms2ger)
Attachment #638122 -
Flags: feedback+
|
||
Comment 3•13 years ago
|
||
Comment on attachment 638122 [details] [diff] [review]
v1
Looks great, thanks!
Attachment #638122 -
Flags: review?(ehsan) → review+
|
|
||
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla16
|
|
Assignee | |
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•