Last Comment Bug 769913 - TestTXMgr.cpp should use fail() from TestHarness.h
: TestTXMgr.cpp should use fail() from TestHarness.h
Status: RESOLVED FIXED
[good first bug][mentor=Ms2ger][lang=...
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Ekanan Ketunuti
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-30 07:29 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-07-02 18:40 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (129.97 KB, patch)
2012-06-30 10:06 PDT, Ekanan Ketunuti
ehsan: review+
Ms2ger: feedback+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-06-30 07:29:36 PDT
The test at <http://mxr.mozilla.org/mozilla-central/source/editor/txmgr/tests/TestTXMgr.cpp> should be changed to use the fail() function defined in <http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/TestHarness.h>.

In particular, every line reading

  printf("ERROR: ...

should instead read

  fail("...
Comment 1 Ekanan Ketunuti 2012-06-30 10:06:52 PDT
Created attachment 638122 [details] [diff] [review]
v1
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-30 11:08:30 PDT
Comment on attachment 638122 [details] [diff] [review]
v1

Review of attachment 638122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Ehsan, can you review?
Comment 3 :Ehsan Akhgari 2012-07-01 11:05:18 PDT
Comment on attachment 638122 [details] [diff] [review]
v1

Looks great, thanks!

Note You need to log in before you can comment on or make changes to this bug.