769930 - Split PSM and NSS builds so that we can build NSS early

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Eric Rescorla (:ekr)]

Attachment: Patch

Some of the WebRTC code invokes NSS directly, so we need to make the NSS build happen earlier. 

The following patch applies against alder/trunk. We will eventually submit one against m-c.

Original patch by glandium. Modifed by EKR.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 638123 [details] [diff] [review]
Patch

This is fine, but slightly longer term we need to figure out how webrtc should interact with --disable-crypto.

Comment 2

[Eric Rescorla (:ekr)]

Attachment: Revised patch, applies on m-c

Still waiting on try server.

Comment 3

[Eric Rescorla (:ekr)]

Try server results:

https://tbpl.mozilla.org/?tree=Try&rev=1e7810b16780

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

I can't review what largely is my own patch ;)

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

Review of attachment 639778 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think there's anything I need to review again.

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #5)
> Comment on attachment 639778 [details] [diff] [review]
> Revised patch, applies on m-c
> 
> Review of attachment 639778 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't think there's anything I need to review again.

So where do we go from here ?

Comment 7

[Mike Hommey [:glandium]]

(In reply to Ludovic Hirlimann [:Usul] from comment #6)
> So where do we go from here ?

We land it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed614ea130c0

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ed614ea130c0