Split PSM and NSS builds so that we can build NSS early

RESOLVED FIXED in mozilla17

Status

()

Core
Security
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ekr, Assigned: ekr)

Tracking

(Depends on: 1 bug)

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 638123 [details] [diff] [review]
Patch

Some of the WebRTC code invokes NSS directly, so we need to make the NSS build happen earlier. 

The following patch applies against alder/trunk. We will eventually submit one against m-c.

Original patch by glandium. Modifed by EKR.
(Assignee)

Updated

5 years ago
Attachment #638123 - Attachment is patch: true
Attachment #638123 - Flags: review?(khuey)
Assignee: nobody → ekr
Status: NEW → ASSIGNED
Comment on attachment 638123 [details] [diff] [review]
Patch

This is fine, but slightly longer term we need to figure out how webrtc should interact with --disable-crypto.
Attachment #638123 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

Still waiting on try server.
Attachment #638123 - Attachment is obsolete: true
(Assignee)

Comment 3

5 years ago
Try server results:

https://tbpl.mozilla.org/?tree=Try&rev=1e7810b16780
(Assignee)

Updated

5 years ago
Attachment #639778 - Flags: review?(mh+mozilla)
Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

I can't review what largely is my own patch ;)
Attachment #639778 - Flags: review?(mh+mozilla) → review?(khuey)
Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

Review of attachment 639778 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think there's anything I need to review again.
Attachment #639778 - Flags: review?(khuey)
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> Comment on attachment 639778 [details] [diff] [review]
> Revised patch, applies on m-c
> 
> Review of attachment 639778 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't think there's anything I need to review again.

So where do we go from here ?
(In reply to Ludovic Hirlimann [:Usul] from comment #6)
> So where do we go from here ?

We land it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed614ea130c0
https://hg.mozilla.org/mozilla-central/rev/ed614ea130c0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 797508
You need to log in before you can comment on or make changes to this bug.