Last Comment Bug 769930 - Split PSM and NSS builds so that we can build NSS early
: Split PSM and NSS builds so that we can build NSS early
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Eric Rescorla (:ekr)
:
: David Keeler [:keeler] (use needinfo?)
Mentors:
Depends on: 797508
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-30 10:16 PDT by Eric Rescorla (:ekr)
Modified: 2012-12-11 20:32 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (12.05 KB, patch)
2012-06-30 10:16 PDT, Eric Rescorla (:ekr)
khuey: review+
Details | Diff | Splinter Review
Revised patch, applies on m-c (11.74 KB, patch)
2012-07-06 13:47 PDT, Eric Rescorla (:ekr)
no flags Details | Diff | Splinter Review

Description Eric Rescorla (:ekr) 2012-06-30 10:16:08 PDT
Created attachment 638123 [details] [diff] [review]
Patch

Some of the WebRTC code invokes NSS directly, so we need to make the NSS build happen earlier. 

The following patch applies against alder/trunk. We will eventually submit one against m-c.

Original patch by glandium. Modifed by EKR.
Comment 1 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-06 11:24:13 PDT
Comment on attachment 638123 [details] [diff] [review]
Patch

This is fine, but slightly longer term we need to figure out how webrtc should interact with --disable-crypto.
Comment 2 Eric Rescorla (:ekr) 2012-07-06 13:47:57 PDT
Created attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

Still waiting on try server.
Comment 3 Eric Rescorla (:ekr) 2012-07-07 00:26:31 PDT
Try server results:

https://tbpl.mozilla.org/?tree=Try&rev=1e7810b16780
Comment 4 Mike Hommey [:glandium] 2012-07-07 00:47:11 PDT
Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

I can't review what largely is my own patch ;)
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-11 09:42:21 PDT
Comment on attachment 639778 [details] [diff] [review]
Revised patch, applies on m-c

Review of attachment 639778 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think there's anything I need to review again.
Comment 6 Ludovic Hirlimann [:Usul] 2012-08-13 02:36:04 PDT
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #5)
> Comment on attachment 639778 [details] [diff] [review]
> Revised patch, applies on m-c
> 
> Review of attachment 639778 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't think there's anything I need to review again.

So where do we go from here ?
Comment 7 Mike Hommey [:glandium] 2012-08-13 02:48:11 PDT
(In reply to Ludovic Hirlimann [:Usul] from comment #6)
> So where do we go from here ?

We land it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed614ea130c0
Comment 8 Ed Morley [:emorley] 2012-08-13 11:10:48 PDT
https://hg.mozilla.org/mozilla-central/rev/ed614ea130c0

Note You need to log in before you can comment on or make changes to this bug.