Last Comment Bug 770121 - GC: Make GC more deterministic when JS_MORE_DETERMINISTIC is defined
: GC: Make GC more deterministic when JS_MORE_DETERMINISTIC is defined
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla16
Assigned To: Jon Coppeard (:jonco) (PTO until 5th September)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-02 03:55 PDT by Jon Coppeard (:jonco) (PTO until 5th September)
Modified: 2012-07-04 09:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make timing related stuff in jsgc.cpp conditional (3.06 KB, patch)
2012-07-02 04:42 PDT, Jon Coppeard (:jonco) (PTO until 5th September)
wmccloskey: review+
Details | Diff | Splinter Review

Description Jon Coppeard (:jonco) (PTO until 5th September) 2012-07-02 03:55:24 PDT
To help ensure that tests runs always produce the same output, we can remove timing related behaviour from the GC when JS_MORE_DETERMINISTIC is defined.

There are three ways GC is affected by time:

 - ReleaseObservedTypes called in the sweep phase triggers every 60 seconds
 - MaybeGC triggers a full GC every 20 seconds (not called from the shell)
 - incremental GC budgets where explicitly requested

The proposal is to make the first two only conditional on this macro being not defined.
Comment 1 Jon Coppeard (:jonco) (PTO until 5th September) 2012-07-02 04:42:14 PDT
Created attachment 638308 [details] [diff] [review]
Make timing related stuff in jsgc.cpp conditional
Comment 2 Jon Coppeard (:jonco) (PTO until 5th September) 2012-07-04 04:45:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/2eb2d4b9a0ef
Comment 3 Ryan VanderMeulen [:RyanVM] 2012-07-04 09:50:37 PDT
https://hg.mozilla.org/mozilla-central/rev/2eb2d4b9a0ef

Note You need to log in before you can comment on or make changes to this bug.