The default bug view has changed. See this FAQ.

GC: Make GC more deterministic when JS_MORE_DETERMINISTIC is defined

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
To help ensure that tests runs always produce the same output, we can remove timing related behaviour from the GC when JS_MORE_DETERMINISTIC is defined.

There are three ways GC is affected by time:

 - ReleaseObservedTypes called in the sweep phase triggers every 60 seconds
 - MaybeGC triggers a full GC every 20 seconds (not called from the shell)
 - incremental GC budgets where explicitly requested

The proposal is to make the first two only conditional on this macro being not defined.
(Assignee)

Updated

5 years ago
Assignee: general → jcoppeard
(Assignee)

Comment 1

5 years ago
Created attachment 638308 [details] [diff] [review]
Make timing related stuff in jsgc.cpp conditional
Attachment #638308 - Flags: review?(wmccloskey)
Attachment #638308 - Flags: review?(wmccloskey) → review+
Whiteboard: [js:t]
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2eb2d4b9a0ef
https://hg.mozilla.org/mozilla-central/rev/2eb2d4b9a0ef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.