770140 - Implement IndirectCrossCompartmentWrapper

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

With Eddy's refactoring of the wrapper hierarchy over in bug 703537, there are now two types of wrappers: IndirectWrappers, which implement derived traps in terms of fundamental traps, and DirectWrappers, which forward everything explicitly.

Currently, CrossCompartmentWrapper inherits DirectWrapper, but it would be nice to have the other one too.

Comment 1

[Bobby Holley (:bholley)]

Templatizing turned out to be the wrong way to go, because it meant that we'd do the cross-compartment wrapper goop twice for a single call when going through the derived traps. I've got a different strategy now.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Introduce IndirectCrossCompartmentWrapper. v1

So, I've got this written. Unfortunately, I discovered that AbstractWrapper semantics
aren't really useful when wrapping arrays, because PropertyOp-implemented things like
.length don't work right with getPropertyDescriptor. So we rely on the special get()
behavior that calls getGeneric() to do the right thing. Lame.

Hopefully someday we'll fix the whole PropertyOp mess. In the mean time though, this
patch isn't useful to me. Posting it here for posterity.

Comment 3

[Bobby Holley (:bholley)]

Indirect wrappers are going away in bug 803068.