Closed Bug 77020 Opened 24 years ago Closed 23 years ago

window.open('url', 'windowName', 'resizable=0') opens window without minimize button

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86
Windows 95
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.9

People

(Reporter: martin.honnen, Assigned: danm.moz)

References

()

Details

(Keywords: testcase, Whiteboard: ADT Need Info)

Attachments

(2 files)

If you open a window with JavaScript and the feature resizable=0 Mozilla opens a window without a minimize button. This is not backwards compliant with earlier browsers which offer the minimize button. I just checked and found that the minimize item is also disabled in the window menu. That is also contrary to the way NN3/4 handle that which allow minimizing of such a window. This is tested on Windows 95 with Mozilla 0.8.1 but I have complaints in newsgroups that NN6 is showing the same behaviour so it is likely no regression but intention of someone who designed the window features for Mozilla. But I think disabling the minimize functionality for resizable=0 is wrong for most scripters intention, they just want to fix the window size for their (d)html layout, but they don't want to prevent the user from minimizing a window.
Reassigning to danm.
Assignee: jst → danm
*** Bug 75135 has been marked as a duplicate of this bug. ***
Target Milestone: --- → Future
Attached file Adding testcase
Both window.open('url', 'windowName', 'resizable=0') or window.open('url', 'windowName', 'resizable=no') open window without minimize button or resize buttons. I feel window.open is very commonly used method & should work from all directions to ensure backword compatibility. Nominating for nsbeta1 & also setting priority=p1 due to high visibility [Please correct if I'm wrong]. adding keyword testcase.
Keywords: nsbeta1, testcase
Priority: -- → P1
Oh alright, if you feel strongly about it. Patch tweaks window features to nearly always get a minimize button regardless of whether it's resizable, as other browsers do. It also fixes uses of window.open in Mozilla chrome which explicitly ask for an unsizable window and (I believe) erroneously specify a non-dialog where the intent was really a dialog. Without that part of the patch these dialogs would suddenly start getting minimize buttons.
Comment on attachment 68605 [details] [diff] [review] windows (but not dialogs) mostly get a minimize button sr=ben@netscape.com
Attachment #68605 - Flags: superreview+
Comment on attachment 68605 [details] [diff] [review] windows (but not dialogs) mostly get a minimize button r=jag
Attachment #68605 - Flags: review+
ADT needs more info. how often do users see this.
Whiteboard: ADT Need Info
Forgot to add this, sorry. My comment above was added based on the ADT/Embedding triage team meeting.
I guess tons of pop-up ads use this. All pop-up windows use window.open & mostly with resizable=0 or resizable=no.
patch checked in late last week
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Target Milestone: Future → mozilla0.9.9
Verified fixed on build 2002021303
Status: RESOLVED → VERIFIED
*** Bug 39028 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: