Closed Bug 770230 Opened 9 years ago Closed 9 years ago

Broken symlinks in webrtc code

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: justin.lebar+bug, Assigned: jesup)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

> $ hg locate | xargs head > /dev/null
> head: cannot open `media/webrtc/trunk/tools/python_charts/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gaeunit.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/oauth2' for reading: No such file or directory

These files are all broken symlinks.  For example

> $ readlink media/webrtc/trunk/tools/python_charts/gviz_api.py
> ../../third_party/google-visualization-python/gviz_api.py
>
> $ hg locate | grep gviz_api.py
> media/webrtc/trunk/tools/python_charts/gviz_api.py
> media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py

Note no third_party directory there.

In general, I thought we couldn't have symlinks in our tree, because Windows does not handle them properly.
Thanks.  Since we were importing 3800ish files with 500K lines of source, some things slipped through (and none of my tools flagged it, even in windows builds, since those probably aren't actually needed except maybe for some tests we aren't running).
Assignee: nobody → rjesup
Comment on attachment 639690 [details] [diff] [review]
Remove broken symlinks to third_party/google-visualization-python

Note that we don't do anything currently with tools/python_charts; if we want to we'll need to import these files.
Attachment #639690 - Flags: review?(tterribe)
Attachment #639690 - Flags: review?(tterribe) → review+
https://hg.mozilla.org/mozilla-central/rev/3477c454d7f3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.