770230 - Broken symlinks in webrtc code

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Justin Lebar (not reading bugmail)]

> $ hg locate | xargs head > /dev/null
> head: cannot open `media/webrtc/trunk/tools/python_charts/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gaeunit.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/oauth2' for reading: No such file or directory

These files are all broken symlinks.  For example

> $ readlink media/webrtc/trunk/tools/python_charts/gviz_api.py
> ../../third_party/google-visualization-python/gviz_api.py
>
> $ hg locate | grep gviz_api.py
> media/webrtc/trunk/tools/python_charts/gviz_api.py
> media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py

Note no third_party directory there.

In general, I thought we couldn't have symlinks in our tree, because Windows does not handle them properly.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Thanks.  Since we were importing 3800ish files with 500K lines of source, some things slipped through (and none of my tools flagged it, even in windows builds, since those probably aren't actually needed except maybe for some tests we aren't running).

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Remove broken symlinks to third_party/google-visualization-python

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 639690 [details] [diff] [review]
Remove broken symlinks to third_party/google-visualization-python

Note that we don't do anything currently with tools/python_charts; if we want to we'll need to import these files.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3477c454d7f3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3477c454d7f3