The default bug view has changed. See this FAQ.

Broken symlinks in webrtc code

RESOLVED FIXED in mozilla16

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: jesup)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
> $ hg locate | xargs head > /dev/null
> head: cannot open `media/webrtc/trunk/tools/python_charts/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gaeunit.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py' for reading: No such file or directory
> head: cannot open `media/webrtc/trunk/tools/quality_tracking/oauth2' for reading: No such file or directory

These files are all broken symlinks.  For example

> $ readlink media/webrtc/trunk/tools/python_charts/gviz_api.py
> ../../third_party/google-visualization-python/gviz_api.py
>
> $ hg locate | grep gviz_api.py
> media/webrtc/trunk/tools/python_charts/gviz_api.py
> media/webrtc/trunk/tools/quality_tracking/dashboard/gviz_api.py

Note no third_party directory there.

In general, I thought we couldn't have symlinks in our tree, because Windows does not handle them properly.
(Assignee)

Comment 1

5 years ago
Thanks.  Since we were importing 3800ish files with 500K lines of source, some things slipped through (and none of my tools flagged it, even in windows builds, since those probably aren't actually needed except maybe for some tests we aren't running).
Assignee: nobody → rjesup
(Assignee)

Comment 2

5 years ago
Created attachment 639690 [details] [diff] [review]
Remove broken symlinks to third_party/google-visualization-python
(Assignee)

Comment 3

5 years ago
Comment on attachment 639690 [details] [diff] [review]
Remove broken symlinks to third_party/google-visualization-python

Note that we don't do anything currently with tools/python_charts; if we want to we'll need to import these files.
Attachment #639690 - Flags: review?(tterribe)
Attachment #639690 - Flags: review?(tterribe) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3477c454d7f3
https://hg.mozilla.org/mozilla-central/rev/3477c454d7f3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.