770268 - jsinfer.h:98:24: warning: inline function ‘js::types::TypeObject* js::types::Type::typeObject() const’ used but never defined [enabled by default] (also for "singleObject() const")

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Just noticed that in my (up-to-date mozilla-central debug) build, I'm getting multiple instances of these 2 warnings:
{
In file included from ../../../mozilla/js/src/jsobj.h:23:0,
                 from ../../../mozilla/js/src/jsfun.h:14,
                 from ../../../mozilla/js/src/vm/Stack.h:11,
                 from ../../../mozilla/js/src/jscntxt.h:32,
                 from ../../../mozilla/js/src/frontend/ParseMaps-inl.h:11,
                 from ../../../mozilla/js/src/frontend/ParseMaps.cpp:8:
../../../mozilla/js/src/jsinfer.h:98:24: warning: inline function ‘js::types::TypeObject* js::types::Type::typeObject() const’ used but never defined [enabled by default]
../../../mozilla/js/src/jsinfer.h:90:22: warning: inline function ‘JSObject* js::types::Type::singleObject() const’ used but never defined [enabled by default]
}

Not exactly sure when this warning was introduced, but I'm flagging a dependency on bug 748119 whose cset moded these functions' impls into a different file.

This appears particularly spammy, since it's in a .h file, which means
  (a) we hit it for multiple .cpp files (at least 11)
  (b) it prints out the whole header-includes route from the .cpp file to jsinfer.h, which adds 6 lines of warning-spam in the case above.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> Not exactly sure when this warning was introduced, but I'm flagging a
> dependency on bug 748119 whose cset moded these functions' impls into a
> different file.

(er, s/moded/moved/)
(also: not suggesting that the moving was a bad thing; just that it's one of the factors involved in triggering this warning.)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c9c5ff6c3559

Comment 3

[Daniel Holbert [:dholbert]]

Yay!

(/me changes dependency to the bug that added the code fixed by the patch in comment 2)

Comment 4

[Daniel Holbert [:dholbert]]

er, we probably meant to mark this FIXED when the cset comment 2 was merged to m-c. Doing so now.  The m-c cset is: https://hg.mozilla.org/mozilla-central/rev/c9c5ff6c3559