The default bug view has changed. See this FAQ.

IDBIndex.h:162:25: warning: ‘...mActorParent’ will be initialized after... ‘...mKeyPath’ [-Wreorder]

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 638448 [details] [diff] [review]
fix

In file included from ../../../mozilla/dom/indexedDB/IDBIndex.cpp:9:0:
../../../mozilla/dom/indexedDB/IDBIndex.h: In constructor ‘mozilla::dom::indexedDB::IDBIndex::IDBIndex()’:
../../../mozilla/dom/indexedDB/IDBIndex.h:162:25: warning: ‘mozilla::dom::indexedDB::IDBIndex::mActorParent’ will be initialized after [-Wreorder]
../../../mozilla/dom/indexedDB/IDBIndex.h:158:11: warning:   ‘mozilla::dom::indexedDB::KeyPath mozilla::dom::indexedDB::IDBIndex::mKeyPath’ [-Wreorder]
../../../mozilla/dom/indexedDB/IDBIndex.cpp:395:1: warning:   when initialized here [-Wreorder]

This is from this block:
395 IDBIndex::IDBIndex()
396 : mId(LL_MININT),
397   mActorChild(nsnull),
398   mActorParent(nsnull),
399   mKeyPath(0),

and mKeyPath is declared before mActorChild in the class, so it should be listed before it in the init list.  Attached patch makes this change.
Attachment #638448 - Flags: review?(khuey)
Attachment #638448 - Flags: review?(khuey) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ea07a17e25c
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/8ea07a17e25c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.