Closed Bug 770289 Opened 9 years ago Closed 9 years ago

JNIEnv->NewString can throw and needs to be caught before another JNI call

Categories

(Core :: Widget: Android, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: blassey, Assigned: blassey)

Details

Attachments

(3 files)

No description provided.
This is basically a search and replace patch. There might be cases where we want to change behavior when there's an exception, but that can be done in a follow up.
Assignee: nobody → blassey.bugs
Attachment #638452 - Flags: review?(bugmail.mozilla)
Attachment #638453 - Flags: review?(bugmail.mozilla)
Attachment #638453 - Flags: review?(bugmail.mozilla) → review+
Comment on attachment 638452 [details] [diff] [review]
patch to add NewJavaString function that returns null

Review of attachment 638452 [details] [diff] [review]:
-----------------------------------------------------------------

There's a couple of calls to NewStringUTF in AndroidBridge::CreateMessageList that need this check as well.
Attachment #638452 - Flags: review?(bugmail.mozilla) → review+
The whiteboard annotation needs to be [leave open] or the new tool we are using will close the bug.

See:
https://wiki.mozilla.org/Tree_Rules/Inbound#Please_do_the_following_after_pushing_to_inbound
and
https://groups.google.com/d/topic/mozilla.dev.platform/DQyQ56DgmhA/discussion
Whiteboard: [keep-open-after-merge] → [leave open]
Attachment #658361 - Flags: review?(bugmail.mozilla)
Attachment #658361 - Flags: review?(bugmail.mozilla) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.