Closed
Bug 770289
Opened 11 years ago
Closed 11 years ago
JNIEnv->NewString can throw and needs to be caught before another JNI call
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: blassey, Assigned: blassey)
Details
Attachments
(3 files)
16.32 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
23.75 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
1.68 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
This is basically a search and replace patch. There might be cases where we want to change behavior when there's an exception, but that can be done in a follow up.
Assignee: nobody → blassey.bugs
Attachment #638452 -
Flags: review?(bugmail.mozilla)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #638453 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #638453 -
Flags: review?(bugmail.mozilla) → review+
Comment 3•11 years ago
|
||
Comment on attachment 638452 [details] [diff] [review] patch to add NewJavaString function that returns null Review of attachment 638452 [details] [diff] [review]: ----------------------------------------------------------------- There's a couple of calls to NewStringUTF in AndroidBridge::CreateMessageList that need this check as well.
Attachment #638452 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a36da70ad3da https://hg.mozilla.org/integration/mozilla-inbound/rev/ba6941b5077e keeping open to do something with NewStringUTF()
Whiteboard: [keep-open-after-merge]
Comment 5•11 years ago
|
||
The whiteboard annotation needs to be [leave open] or the new tool we are using will close the bug. See: https://wiki.mozilla.org/Tree_Rules/Inbound#Please_do_the_following_after_pushing_to_inbound and https://groups.google.com/d/topic/mozilla.dev.platform/DQyQ56DgmhA/discussion
Whiteboard: [keep-open-after-merge] → [leave open]
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a36da70ad3da https://hg.mozilla.org/mozilla-central/rev/ba6941b5077e
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #658361 -
Flags: review?(bugmail.mozilla)
Updated•11 years ago
|
Attachment #658361 -
Flags: review?(bugmail.mozilla) → review+
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc77641d45f8
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Updated•1 year ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•