770289 - JNIEnv->NewString can throw and needs to be caught before another JNI call

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch to add NewJavaString function that returns null

This is basically a search and replace patch. There might be cases where we want to change behavior when there's an exception, but that can be done in a follow up.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: follow up patch to fix whitespace

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 638452 [details] [diff] [review]
patch to add NewJavaString function that returns null

Review of attachment 638452 [details] [diff] [review]:
-----------------------------------------------------------------

There's a couple of calls to NewStringUTF in AndroidBridge::CreateMessageList that need this check as well.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a36da70ad3da
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba6941b5077e

keeping open to do something with NewStringUTF()

Comment 5

[Ed Morley [:emorley]]

The whiteboard annotation needs to be [leave open] or the new tool we are using will close the bug.

See:
https://wiki.mozilla.org/Tree_Rules/Inbound#Please_do_the_following_after_pushing_to_inbound
and
https://groups.google.com/d/topic/mozilla.dev.platform/DQyQ56DgmhA/discussion

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a36da70ad3da
https://hg.mozilla.org/mozilla-central/rev/ba6941b5077e

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch for NewStringUTF

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc77641d45f8