MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla16
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Newish build warning:

In file included from ../../../mozilla/layout/base/MaskLayerImageCache.cpp:6:0:
../../../mozilla/layout/base/MaskLayerImageCache.h: In member function ‘void mozilla::MaskLayerImageCache::PixelRoundedRect::ScaleAndTranslate(const gfxMatrix&)’:
../../../mozilla/layout/base/MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

from:
>  for (int i = 0; i < ArrayLength(mRadii); i += 2) {

ArrayLength returns size_t (which is unsigned).

i should be PRUint32 or size_t.
(Assignee)

Updated

5 years ago
Component: Video/Audio → Graphics: Layers
QA Contact: video.audio → graphics-layers
Summary: /MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] → MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(Assignee)

Comment 1

5 years ago
Created attachment 638463 [details] [diff] [review]
fix: use size_t
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #638463 - Flags: review?(ncameron)

Comment 2

5 years ago
Comment on attachment 638463 [details] [diff] [review]
fix: use size_t

Review of attachment 638463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!
Attachment #638463 - Flags: review?(ncameron) → review+
(Assignee)

Comment 3

5 years ago
No problem -- thanks for the quick response!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d5401de5683
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/0d5401de5683
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.