Closed Bug 770299 Opened 7 years ago Closed 7 years ago

MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Newish build warning:

In file included from ../../../mozilla/layout/base/MaskLayerImageCache.cpp:6:0:
../../../mozilla/layout/base/MaskLayerImageCache.h: In member function ‘void mozilla::MaskLayerImageCache::PixelRoundedRect::ScaleAndTranslate(const gfxMatrix&)’:
../../../mozilla/layout/base/MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

from:
>  for (int i = 0; i < ArrayLength(mRadii); i += 2) {

ArrayLength returns size_t (which is unsigned).

i should be PRUint32 or size_t.
Component: Video/Audio → Graphics: Layers
QA Contact: video.audio → graphics-layers
Summary: /MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] → MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
Attached patch fix: use size_tSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #638463 - Flags: review?(ncameron)
Comment on attachment 638463 [details] [diff] [review]
fix: use size_t

Review of attachment 638463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!
Attachment #638463 - Flags: review?(ncameron) → review+
No problem -- thanks for the quick response!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d5401de5683
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/0d5401de5683
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.