Last Comment Bug 770299 - MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
: MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned ...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics: Layers (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: Daniel Holbert [:dholbert]
:
:
Mentors:
Depends on:
Blocks: buildwarning 757347
  Show dependency treegraph
 
Reported: 2012-07-02 12:54 PDT by Daniel Holbert [:dholbert]
Modified: 2012-07-03 16:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix: use size_t (649 bytes, patch)
2012-07-02 12:57 PDT, Daniel Holbert [:dholbert]
ncameron: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-07-02 12:54:15 PDT
Newish build warning:

In file included from ../../../mozilla/layout/base/MaskLayerImageCache.cpp:6:0:
../../../mozilla/layout/base/MaskLayerImageCache.h: In member function ‘void mozilla::MaskLayerImageCache::PixelRoundedRect::ScaleAndTranslate(const gfxMatrix&)’:
../../../mozilla/layout/base/MaskLayerImageCache.h:67:45: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

from:
>  for (int i = 0; i < ArrayLength(mRadii); i += 2) {

ArrayLength returns size_t (which is unsigned).

i should be PRUint32 or size_t.
Comment 1 Daniel Holbert [:dholbert] 2012-07-02 12:57:24 PDT
Created attachment 638463 [details] [diff] [review]
fix: use size_t
Comment 2 Nick Cameron [:nrc] 2012-07-02 17:01:16 PDT
Comment on attachment 638463 [details] [diff] [review]
fix: use size_t

Review of attachment 638463 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fix!
Comment 3 Daniel Holbert [:dholbert] 2012-07-03 09:05:12 PDT
No problem -- thanks for the quick response!
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d5401de5683
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-03 16:07:25 PDT
https://hg.mozilla.org/mozilla-central/rev/0d5401de5683

Note You need to log in before you can comment on or make changes to this bug.