770351 - PrivateDataPreference dialog resets checked state on orientation change

Status: RESOLVED DUPLICATE of bug 770345

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is for trunk/Nightly only - the dialog is not yet in Aurora.

1) Open Fennec.
2) Click the more options menu (three horizontal lines)
3) Scroll down and select "Settings".
4) On the preferences screen, select "Clear private data".
5) Uncheck "Browsing & download history".
6) Rotate the device so the orientation changes.

Expected: The dialog maintains state so that "Browsing & download history" remains unchecked.
Actual: The dialog returns to the state it was in previously, where "Browsing & download history" was checked.

Unlike bug 770345, this dialog will still work correctly to clear settings after the rotation is changed (though the checkboxes/options need to be reset to the desired values).

Tested on Galaxy Nexus, Android 4.0.4, and Asus Transformer Prime TF201, Android 4.0.3.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I believe this can use DialogPreference.onSaveInstanceState(...) (http://developer.android.com/reference/android/preference/DialogPreference.html#onSaveInstanceState()) and onRestoreInstanceState(...).

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Fixed with the patch from Bug 770345.