Closed Bug 770371 Opened 11 years ago Closed 11 years ago

Tapping to copy selected text is too hard when the text is small

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

Product:
Firefox for Android Graveyard
Component:
Text Selection
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v2
4.46 KB, patch
Margaret
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
To copy text, you have to tap within the selected text.  When the text is fairly small (for example, if the page is zoomed out), it's too easy to tap outside of the selection by accident.  We should add a small margin to the the tappable area to make it easier to hit.
Attached patch patch (obsolete) — — Splinter Review 
I still need to test this, but I think it'll do the trick.
Attached patch patch v2 — — Splinter Review 

        Attachment #638537 -
        Attachment is obsolete: true

        Attachment #638550 -
        Flags: review?(margaret.leibovic)

    
  
Blocks: text-selection

    
  

        Attachment #638550 -
        Flags: review?(margaret.leibovic) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/166fc54b3964
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16

    
    

    
  
Comment on attachment 638550 [details] [diff] [review]
patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this should be part of the text selection mass uplift (bug 695173), but was fixed after the roll-up patch in that bug was created
User impact if declined: tapping to copy text is too hard
Testing completed (on m-c, etc.): landed on m-c 7/3
Risk to taking this patch (and alternatives if risky): low risk 
String or UUID changes made by this patch: n/a

        Attachment #638550 -
        Flags: approval-mozilla-aurora?

    
  

        Attachment #638550 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6

          status-firefox15:
          --- → fixed

          status-firefox16:
          --- → fixed
Component: General → Text Selection
Status: RESOLVED → VERIFIED

          status-firefox15:
          fixed → verified

          status-firefox16:
          fixed → verified

          status-firefox17:
          --- → verified

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.