logging output is grody in identity/LogUtils.jsm

RESOLVED FIXED in mozilla16

Status

()

Core
Identity
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jedp, Assigned: MattN)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

the prefix and optional args array (prefix, ...args) aren't playing well with each other.  it looks like args is coming out as a stringified array, not a list of strings.
Created attachment 640880 [details] [diff] [review]
v.1 Fix calls to log and cleanup usage

This was bothering me and made other problems harder to debug. If this is reviewed in time, I'll land this with the DOM code tonight.
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Attachment #640880 - Flags: review?(jparsons)
Attachment #640880 - Flags: review?(dolske)
Comment on attachment 640880 [details] [diff] [review]
v.1 Fix calls to log and cleanup usage

Review of attachment 640880 [details] [diff] [review]:
-----------------------------------------------------------------

That's beautiful.

Thanks both for fixing the log output and also for adding the stacktrace on error - that's going to be very helpful

r+
Attachment #640880 - Flags: review?(jparsons) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c84e7d4fb37a

rs=dolske on IRC
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Attachment #640880 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/c84e7d4fb37a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.