Closed Bug 770418 Opened 8 years ago Closed 8 years ago

logging output is grody in identity/LogUtils.jsm

Categories

(Core Graveyard :: Identity, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: jedp, Assigned: MattN)

Details

Attachments

(1 file)

the prefix and optional args array (prefix, ...args) aren't playing well with each other.  it looks like args is coming out as a stringified array, not a list of strings.
This was bothering me and made other problems harder to debug. If this is reviewed in time, I'll land this with the DOM code tonight.
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Attachment #640880 - Flags: review?(jparsons)
Attachment #640880 - Flags: review?(dolske)
Comment on attachment 640880 [details] [diff] [review]
v.1 Fix calls to log and cleanup usage

Review of attachment 640880 [details] [diff] [review]:
-----------------------------------------------------------------

That's beautiful.

Thanks both for fixing the log output and also for adding the stacktrace on error - that's going to be very helpful

r+
Attachment #640880 - Flags: review?(jparsons) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c84e7d4fb37a

rs=dolske on IRC
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Attachment #640880 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/c84e7d4fb37a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.