Closed
Bug 770418
Opened 13 years ago
Closed 13 years ago
logging output is grody in identity/LogUtils.jsm
Categories
(Core Graveyard :: Identity, defect)
Core Graveyard
Identity
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: jedp, Assigned: MattN)
Details
Attachments
(1 file)
|
15.41 KB,
patch
|
jedp
:
review+
MattN
:
review+
|
Details | Diff | Splinter Review |
the prefix and optional args array (prefix, ...args) aren't playing well with each other. it looks like args is coming out as a stringified array, not a list of strings.
|
Assignee | |
Comment 1•13 years ago
|
||
This was bothering me and made other problems harder to debug. If this is reviewed in time, I'll land this with the DOM code tonight.
Assignee: nobody → mnoorenberghe+bmo
Status: NEW → ASSIGNED
Attachment #640880 -
Flags: review?(jparsons)
Attachment #640880 -
Flags: review?(dolske)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 640880 [details] [diff] [review]
v.1 Fix calls to log and cleanup usage
Review of attachment 640880 [details] [diff] [review]:
-----------------------------------------------------------------
That's beautiful.
Thanks both for fixing the log output and also for adding the stacktrace on error - that's going to be very helpful
r+
Attachment #640880 -
Flags: review?(jparsons) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c84e7d4fb37a
rs=dolske on IRC
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
|
|
Assignee | |
Updated•13 years ago
|
Attachment #640880 -
Flags: review?(dolske) → review+
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•