770482 - [socorro-crashstats][UI] ADU - throttle selector needs to be removed

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

Quoting :jberkus here: "The throttle selector needs to go away.  Throttling is determined by the processors/database, not by the users." from https://bugzilla.mozilla.org/show_bug.cgi?id=757826#c5

Comment 1

[Robert Kaiser]

That said, we should still show *somewhere* (in the table is enough) what throttle factor is being applied to numbers for a certain release. Having the user set it is not what we want, though.

Comment 2

[Schalk Neethling [:espressive]]

[:kairo] Yes, I will keep the throttle display values in the table.

Comment 3

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/759

TEST CASE
---------

Navigate to Crashes per ADU. All throttle selectors in the three panels on the left should be removed but, throttle levels should still be displayed in the table at the bottom of the table.

No functionality should be effected by this change.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/501720cf07b351599d40bf167c81aecabf894b16
removing throttle selectors and relevant code from webapp fixes bug 770482

Comment 5

[Matt Brandt [:mbrandt]]

The new UI looks great! Although when I query for ADUs on dev I do not see any results, is this expected?

https://crash-stats-dev.allizom.org/daily?form_selection=by_version&p=Firefox&v[]=17.0a1&v[]=16.0a2&v[]=15.0b6&v[]=14.0.1&hang_type=any&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-08-01&date_end=2012-08-27&submit=Generate

https://crash-stats-dev.allizom.org/daily?form_selection=by_os&p=Firefox&v[]=16.0a2&hang_type=any&date_start=2012-08-01&date_end=2012-08-27&submit=Generate

https://crash-stats-dev.allizom.org/daily?form_selection=by_report_type&p=Firefox&v[]=16.0a2&v[]=17.0a1&v[]=15.0&v[]=14.0.1&report_type[]=crash&report_type[]=oopp&report_type[]=hang_browser&report_type[]=hang_plugin&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-08-01&date_end=2012-08-27&submit=Generate

Comment 6

[Schalk Neethling [:espressive]]

Matt, yep, this is currently expected. I am finishing up the work on this page and it should be pushed in the next day.

Comment 7

[Matt Brandt [:mbrandt]]

Ah I see... many thanks espressive. I'll wait for bug 771129 to land and verify them both for a twofer :)

Comment 8

[Matt Brandt [:mbrandt]]

Reopening:

I ran the queries in comment 5 against stage -- they return the expected results except for 

https://crash-stats.allizom.org/daily?form_selection=by_report_type&p=Firefox&v[]=16.0a2&v[]=17.0a1&v[]=15.0&v[]=14.0.1&report_type[]=crash&report_type[]=oopp&report_type[]=hang_browser&report_type[]=hang_plugin&os[]=Windows&os[]=Mac&os[]=Linux&date_start=2012-08-01&date_end=2012-08-27&submit=Generate

Which returns a 500 error.

Comment 9

[Matt Brandt [:mbrandt]]

Thanks espressive for the clarification -- comment 8 is a separate issue -- filed bug 790383.

Bumping back to fixed :)

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - verified by OS report

QA verified on stage -- the throttle selector for the ADU by Version and ADU by O/S reports have been removed

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - verified by Version report

Comment 12

[Schalk Neethling [:espressive]]

Reopening as this needs to be implemented on new crash stats as well.

Comment 13

[Schalk Neethling [:espressive]]

Sent and merged: https://github.com/mozilla/socorro-crashstats/pull/107