Closed Bug 770623 Opened 12 years ago Closed 12 years ago

IonMonkey: Use SSA for MBoundsCheck

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Patch
26.02 KB, patch
dvander
: review+
Details | Diff | Splinter Review 
We should change MBoundsCheck to redefine the index, so that we can use SSA to track its dependencies.

Atm LICM/GVN guarantee a load/store is never moved before its bounds check so there's no problem, but this will change with bug 722708 (and it will help range analysis).
Attached patch Patch — — Splinter Review 
As discussed before, the main difficulty here was factoring out the redundant bounds check elimination from GVN into a new pass. The algorithm is similar to GVN (use a hash map to find dominating bounds checks) but I think it's nice to have it as a separate pass.
Attachment #639005 - Flags: review?(dvander)
Attachment #639005 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/950259d801c4
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.