Last Comment Bug 770663 - Add a JS shell function to turn on a static profiling stack
: Add a JS shell function to turn on a static profiling stack
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: u443197
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on: 761261 830544
Blocks: 774343
  Show dependency treegraph
 
Reported: 2012-07-03 13:54 PDT by u443197
Modified: 2013-01-14 15:47 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.34 KB, patch)
2012-07-05 11:06 PDT, u443197
luke: review+
Details | Diff | Splinter Review

Description u443197 2012-07-03 13:54:53 PDT
With the profiling from bug 761261, there should be validation that the instrumentation remains consistent. To do this, a function should be added to the shell to turn on a static profiling stack to be called from fuzzers.

This function would turn on profiling for the runtime, which in debug builds would assert that function entry/exit are tracked accordingly.
Comment 1 u443197 2012-07-05 11:06:19 PDT
Created attachment 639398 [details] [diff] [review]
patch
Comment 2 Luke Wagner [:luke] 2012-07-05 14:34:33 PDT
Comment on attachment 639398 [details] [diff] [review]
patch

Cool!
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-08 10:51:19 PDT
https://hg.mozilla.org/mozilla-central/rev/ec41fa92504f
Comment 5 Jesse Ruderman 2012-07-15 21:55:52 PDT
This should probably be in js/src/builtin/TestingFunctions.cpp rather than js/src/shell/js.cpp so it can be tested in the browser as well.

Note You need to log in before you can comment on or make changes to this bug.