770698 - b2g does not compile with --disable-b2g-ril

Status: RESOLVED DUPLICATE of bug 920551

(Firefox OS Graveyard :: General, defect)

Description

[Oleg Romashin (:romaxa)]

Attachment: Fix build without RIL

Looks like we don't compile dom/system/gonk if ril disabled... this does not sounds right.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 638883 [details] [diff] [review]
Fix build without RIL

philikon, does this look ok to you?

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 638883 [details] [diff] [review]
Fix build without RIL

Review of attachment 638883 [details] [diff] [review]:
-----------------------------------------------------------------

The question that I have about this is: will B2G desktop builds with --enable-b2g-ril still compile *and* work? I don't see how since we would never go down into dom/system/gonk yet depend on some of those interfaces in other places.

Making --enable-b2g-ril without Gonk work is something we like to have, whereas --disable-b2g-ril on Gonk isn't necessarily. So I'm inclined to r- this. CCing qDot, maybe he has an idea. But unless this is somehow a blocker, I don't feel like we should spend too many cycles on this. Sorry.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 638883 [details] [diff] [review]
Fix build without RIL

Review of attachment 638883 [details] [diff] [review]:
-----------------------------------------------------------------

Note that this is almost-not-quite a dupe of bug 749824, as we really do need to clean up and divide out our device ifdefs. However, thru V1 I think we should stick with the way things are (even though it's silly) because breaking anything in the workers this close to M4 would equal death to all involved. Not saying this isn't a good idea though. :)

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Bug 920551 is working on removing MOZ_B2G_RIL defines, and the new setup will mean dom/system/gonk is no longer built into b2g-desktop, which should fix this bug.