770809 - [HiDPI] misc. icons appearing on bookmark bar, tabs (and sometimes other locations)

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[philippe (part-time)]

Attachment: misc. icons, v1.0

Included icons:
bm_favicon.tiff
bm_separator.tiff
bookmark_group_badge.tiff
smallbookmark.tiff
smallDocument.tiff

Derek, can you make sure the badge on the bookmark-group icon appears correctly ? It should look like this (I hope…):

http://dev.l-c-n.com/camino/_d/bmg-badge.png

But for whatever reason, it never displays correctly on my side in HiDPI mode.

Comment 1

[philippe (part-time)]

Attachment: screenshot

The Bookmarks-group badge and associated folder are visibly wrong :-(. The folder should look like the other folder(s) on the bookmark bar. Hopefully that is only a problem on my side.

Comment 2

[Derek Schrock]

Comment on attachment 638998 [details]
misc. icons, v1.0

Everything looks good.

The bookmark-group icon looks like your reference image on the MBP Retina.

Comment 3

[philippe (part-time)]

(In reply to Derek Schrock from comment #2)
 
> The bookmark-group icon looks like your reference image on the MBP Retina.

Yay! One less worry.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

bm_favicon:

In the 1x member, the edges of the bottom of the bookmark look darker than before, particularly the right-side "triangle".  Can these be lightened up just a little, particularly the 1 dark pixel in the "middle" of that right-side triangle?  (It may carry over a tiny bit into the 2x member, but with the extra pixels, there's more room for a gradient and I think we mostly luck out with lighter pixels.)


bm_separator:

This seems fine.  (It's possible that it looks a bit fainter than before in the scaled-down 2x screenshot, but given that it looks exactly identical in pixels, I'm writing that possible variance off on the old screenshot-scaling issue.)


bookmark_group_badge:

The 2x member is 2px shorter than the 1x member (18px vs 10px), which raises a question.  I guess it's sort of difficult to gauge original design intent from the 1x version, but I always perceived the 1x version as going "over the top edge" of the folder and down the inside, _somewhat_ like in manager.tiff, rather than just stopping at the top edge.  (Looking at the pre-10.5 groupbookmark, it looks like the intent with that old folder-type was to stop at the edge, but, again, two different folder types here.)

Did you experiment with making the 2x badge 19px high, so that it appears to go over the edge just slightly, by that 1px?  If you haven't, could you?

(TBH, I'd also like to see bm_favicon, at least in 2x mode, adopting more of the "mark-flowing-over-the-pages" look of manager.tiff.  I don't know if it's possible to do that in a way that looks good in 1x, given the pixel constraints there.)

It also looks like the 1x member has the same "extra-dark" pixel in the middle of the right-side triangle as bm_favicon does.


smallbookmark:

I noticed in the 2x version that the right side of the mark seems 2px thinner than the (doubled) 1x version, so that the right side looks a bit "squished".  The existing 1x version I know is a little thinner/slightly lopsided, but it seems worse in 2x.

It also sort of looks fuzzier in 2x mode than 1x mode; I think maybe this is because 1 larger pixel is crisper than all of these smaller ones?  Is there any way to make the edges a bit sharper (changing the colors that dither, maybe)?

(Also, this was a horrible name for an icon, since we never had a "largebookmark" AFAIK :-P  Oh well, not your fault ;-) )


smallDocument:

The 2x member has rounder corners, while the 1x members (old and new) are very square.  I really think that in this universe we should have square corners on our sheets of paper ;-)


I think these are close, despite the length of comments; the r- really only covers a few stray pixels.  Sorry again for the delay in getting to v1.0 of these.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 638998 [details]
misc. icons, v1.0

Er, I forgot to paste my comment from the bug to the review :-(  See comment 4.

Comment 6

[philippe (part-time)]

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #4)

> bookmark_group_badge:
> 
> The 2x member is 2px shorter than the 1x member (18px vs 10px), which raises
> a question.

Right, the @2x icon is indeed slightly shorter because the folder icon itself is different - whereas the @1x folder has just one straight edge (and the badge its against / on it), the @2x folder has more details in the top part. The way I made it was partially inspired by the look of the old groupbookmark folder. In the attached screenshot it doesn’t look the way it should :-(; it should really look like the screenshot linked in comment 0.

I’ll try to tweak it a little to get a similar effect as the manager.tiff icon At least for the @2x icon; the @1x icons just doesn’t have enough pixels to pull it off.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Screenshot of Bookmark Manager in 2x simulation on 10.5

(In reply to philippe (part-time) from comment #6)
> Right, the @2x icon is indeed slightly shorter because the folder icon
> itself is different - whereas the @1x folder has just one straight edge (and
> the badge its against / on it), the @2x folder has more details in the top
> part. 

I did notice that the 2x folder icon was different/more detailed, and going up 20px would have looked terrible ;-)

> The way I made it was partially inspired by the look of the old
> groupbookmark folder. In the attached screenshot it doesn’t look the way it
> should :-(; it should really look like the screenshot linked in comment 0.

What I saw was like the screenshot linked in comment 0, so I was seeing the right thing :-)  (One of my bmbar folders, News, has no solid border in 2x mode, but everywhere else I'm always seeing the right thing, including folder groups, and News in the manager itself.)

I just think, based on what I have seen for years in the 10.5+ 1x icon, that for 10.5+ style folders, we should go over the edge of the folder flap (or at least see what it looks like; if it's awful we'll stick to this design) :-)

> I’ll try to tweak it a little to get a similar effect as the manager.tiff
> icon At least for the @2x icon; the @1x icons just doesn’t have enough
> pixels to pull it off.

Thanks :-)

Comment 8

[philippe (part-time)]

Looking at your screenshot, the badged folder looks way better than in HiDPI mode on 10.8 or 2x simulation on 10.6 :-(

Is this a possibility ?
http://dev.l-c-n.com/camino/_d/bookmarkgroupbadge.png
(on 10.6, and the only place where I can get it to display correctly: on the bm-bar - at least that matches a simulation in Photoshop)

One problem with trying to realise this: in manager.tiff, the 'overlap' part at the top of the badge extends to the right of the badge; that is something I cannot do in this case, it would require changing the image sizes (for both icons, as the sizes must match)

Comment 9

[philippe (part-time)]

Attachment: icons v1.1

Updated per comments;

This contains the bookmark_group_badge icon as shown in comment 8

Also included is an alternative @2x smallDocument (in an ‘alt’ folder) in addition to the updated icon as was included before. this alt icon has ‘1px’ borders instead of ‘2px’.

screenshot for that icon:
http://dev.l-c-n.com/camino/_d/alt-smallDocument.png

Comment 10

[philippe (part-time)]

Attachment: screenshot v1.1

The bookmark_group_badge still displays wrong in HiDPI mode here :-(
Refer to the link in comment 8 for what it ought to look like.

http://dev.l-c-n.com/camino/_d/bookmarkgroupbadge.png

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to philippe (part-time) from comment #8)
> Looking at your screenshot, the badged folder looks way better than in HiDPI
> mode on 10.8

8O

> Is this a possibility ?
> http://dev.l-c-n.com/camino/_d/bookmarkgroupbadge.png

Maybe?  At first glance it looks a little strange, so I'll have to stare-think about it.

> One problem with trying to realise this: in manager.tiff, the 'overlap' part
> at the top of the badge extends to the right of the badge; that is something
> I cannot do in this case, it would require changing the image sizes (for
> both icons, as the sizes must match)

Can't you add the appropriate amount of (transparent) pixels to the 1x version (and change http://mxr.mozilla.org/camino/source/camino/src/bookmarks/BookmarkFolder.mm#280 as needed)?

(In reply to philippe (part-time) from comment #9)
> Also included is an alternative @2x smallDocument (in an ‘alt’ folder) in
> addition to the updated icon as was included before. this alt icon has ‘1px’
> borders instead of ‘2px’.

At first glance, it seems like the alt icon is sharper (and more consistent with, say, the 2x folder icons from the OS), although the black line at the bottom of the document is fainter.  I'm not sure that a fainter black line at the bottom is a problem, though.

Derek, if you have a chance, can you look at the updated bookmark_group_badge and alt smallDocument in real HiDPI and give some comments?  /me tries this "Need additional information" thingy…

Comment 12

[philippe (part-time)]

Attachment: icons v1.2

(In reply to Smokey Ardisson (not following bugs - do not email) from comment #11)

> Can't you add the appropriate amount of (transparent) pixels to the 1x
> version (and change
> http://mxr.mozilla.org/camino/source/camino/src/bookmarks/BookmarkFolder.
> mm#280 as needed)?

Aha, there it is. Thanks for the pointer.

Ok, so making the @1x badge 2px (1px on each side) wider solves the design problem; updated image (in context):
http://dev.l-c-n.com/camino/_d/bmg-badge1.png (<-- bm bar)
http://dev.l-c-n.com/camino/_d/bmg-badge2.png (<-- bm manager)

test build (the updated icons are included):
http://dev.l-c-n.com/camino/_d/Camino.dmg

I've also included the 'alt' smallDocument as default. The bottom border has the same color as the @1x, namely rgb(0,0,0).

Comment 13

[philippe (part-time)]

Attachment: patch, BookmarkFolder.mm

Comment 14

[Derek Schrock]

Should bm_favicon.tiff have the same faint-green bookmark (going inside the book I would assume) like manager.tiff from the toolbar icon? 

Everything else looks good on real HiDPI.

Once you address the above question I'll either +/- feedback.

Comment 15

[philippe (part-time)]

Attachment: alt bm_favicon

(In reply to Derek Schrock from comment #14)
> Should bm_favicon.tiff have the same faint-green bookmark (going inside the
> book I would assume) like manager.tiff from the toolbar icon? 

Should it? I think it is a bit overkill, personally. I see that favicon as an abstract representation of the concept. I don't think it (the bookmark overlapping into the book) adds anything to the concept of the icon.
Anyway, it looks like this:
http://dev.l-c-n.com/camino/_d/alt-bm_favicon.png

(and attached it is the icon)

I'm not really in favor if it.

> Everything else looks good on real HiDPI.
:-)

Comment 16

[Derek Schrock]

Comment on attachment 670665 [details]
icons v1.2

(In reply to philippe (part-time) from comment #15)
> Created attachment 671182 [details]
> alt bm_favicon
> 
> (In reply to Derek Schrock from comment #14)

> 
> Should it? I think it is a bit overkill, personally. I see that favicon as
> an abstract representation of the concept. I don't think it (the bookmark
> overlapping into the book) adds anything to the concept of the icon.
> Anyway, it looks like this:
> http://dev.l-c-n.com/camino/_d/alt-bm_favicon.png
> 
> (and attached it is the icon)
> 
> I'm not really in favor if it.

I like it.  However, I'll let someone that's not me make the decision on which icon to use.