770881 - [ar] post-landing review of changes to region.properties

Status: RESOLVED FIXED

(Mozilla Localizations :: ar / Arabic, defect)

Description

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/l10n/mozilla-beta/ar/diff/a1ab169c4ce1/browser/chrome/browser-region/region.properties added Bing as an ordered plugin, it wasn't before. http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/diff/506939d5eb7f/browser/chrome/browser-region/region.properties is the corresponding change on aurora.

That should be fine, but please make sure that your localization process doesn't change region.properties. Changes to that file need a bug upfront, and review. https://developer.mozilla.org/en/Productization_patches has a detailed description.

Milos, any follow-ups required?

Comment 1

[Khaled Hosny]

Sorry for that. In the rush to get aurora and beta translated before the 17th, I didn’t pay very close attention to the fact I was editing region.properties as well.

Comment 2

[Milos Dinic [:Milos]]

Khaled,

So, you intentionally added Bing? Is this the change you want?

Axel, given the change simplicity, I'm fine with post-landing review, i.e. r+.

Comment 3

[Khaled Hosny]

That right, I don’t see we wouldn’t want Bing in Arabic locale as well.

Comment 4

[Milos Dinic [:Milos]]

Then it's r+ on my side. Axel, feedback?

Comment 5

[Axel Hecht [:Pike]]

Sounds good to me.

Also, to clarify, bing was already in the searchplugins, it's now just explicitly ordered.