Seperate DumpAsDataURL into MOZ_DUMP_IMAGES

RESOLVED FIXED in mozilla16

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 639163 [details] [diff] [review]
patch

Currently there's no easy way to get DumpAsDataURL without enabling MOZ_DUMP_PAINTING and it doesn't work on android. This patch fixes this to be able to inspect images.
Attachment #639163 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #639163 - Flags: review? → review?(ajuma)

Comment 1

5 years ago
Comment on attachment 639163 [details] [diff] [review]
patch

Review of attachment 639163 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxASurface.cpp
@@ +791,5 @@
>    string.Append(encodedImg);
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {

Do this for stderr too.

@@ +792,5 @@
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {
> +       // ADB logcat cut off long string so we will break it down

"cuts off long strings"

::: gfx/thebes/gfxASurface.h
@@ +5,5 @@
>  
>  #ifndef GFX_ASURFACE_H
>  #define GFX_ASURFACE_H
>  
> +#define MOZ_DUMP_IMAGES

Don't forget to remove this before landing!
Attachment #639163 - Flags: review?(ajuma) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 639401 [details] [diff] [review]
patch

r=ajuma
Assignee: nobody → bgirard
Attachment #639163 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #639401 - Flags: review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9b55369267
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/5e9b55369267
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.