770988 - Seperate DumpAsDataURL into MOZ_DUMP_IMAGES

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Currently there's no easy way to get DumpAsDataURL without enabling MOZ_DUMP_PAINTING and it doesn't work on android. This patch fixes this to be able to inspect images.

Comment 1

[Ali Juma [:ajuma]]

Comment on attachment 639163 [details] [diff] [review]
patch

Review of attachment 639163 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxASurface.cpp
@@ +791,5 @@
>    string.Append(encodedImg);
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {

Do this for stderr too.

@@ +792,5 @@
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {
> +       // ADB logcat cut off long string so we will break it down

"cuts off long strings"

::: gfx/thebes/gfxASurface.h
@@ +5,5 @@
>  
>  #ifndef GFX_ASURFACE_H
>  #define GFX_ASURFACE_H
>  
> +#define MOZ_DUMP_IMAGES

Don't forget to remove this before landing!

Comment 2

[Benoit Girard (:BenWa)]

Attachment: patch

r=ajuma

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e9b55369267

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e9b55369267