Last Comment Bug 770988 - Seperate DumpAsDataURL into MOZ_DUMP_IMAGES
: Seperate DumpAsDataURL into MOZ_DUMP_IMAGES
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-04 13:11 PDT by Benoit Girard (:BenWa)
Modified: 2012-07-05 17:19 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (6.06 KB, patch)
2012-07-04 13:11 PDT, Benoit Girard (:BenWa)
ajuma.bugzilla: review+
Details | Diff | Splinter Review
patch (6.30 KB, patch)
2012-07-05 11:08 PDT, Benoit Girard (:BenWa)
bgirard: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-07-04 13:11:43 PDT
Created attachment 639163 [details] [diff] [review]
patch

Currently there's no easy way to get DumpAsDataURL without enabling MOZ_DUMP_PAINTING and it doesn't work on android. This patch fixes this to be able to inspect images.
Comment 1 Ali Juma [:ajuma] 2012-07-04 13:37:33 PDT
Comment on attachment 639163 [details] [diff] [review]
patch

Review of attachment 639163 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxASurface.cpp
@@ +791,5 @@
>    string.Append(encodedImg);
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {

Do this for stderr too.

@@ +792,5 @@
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {
> +       // ADB logcat cut off long string so we will break it down

"cuts off long strings"

::: gfx/thebes/gfxASurface.h
@@ +5,5 @@
>  
>  #ifndef GFX_ASURFACE_H
>  #define GFX_ASURFACE_H
>  
> +#define MOZ_DUMP_IMAGES

Don't forget to remove this before landing!
Comment 2 Benoit Girard (:BenWa) 2012-07-05 11:08:11 PDT
Created attachment 639401 [details] [diff] [review]
patch

r=ajuma
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-07-05 17:19:25 PDT
https://hg.mozilla.org/mozilla-central/rev/5e9b55369267

Note You need to log in before you can comment on or make changes to this bug.