Closed Bug 770988 Opened 8 years ago Closed 8 years ago

Seperate DumpAsDataURL into MOZ_DUMP_IMAGES

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Currently there's no easy way to get DumpAsDataURL without enabling MOZ_DUMP_PAINTING and it doesn't work on android. This patch fixes this to be able to inspect images.
Attachment #639163 - Flags: review?
Attachment #639163 - Flags: review? → review?(ajuma)
Comment on attachment 639163 [details] [diff] [review]
patch

Review of attachment 639163 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxASurface.cpp
@@ +791,5 @@
>    string.Append(encodedImg);
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {

Do this for stderr too.

@@ +792,5 @@
>  
>    if (aFile) {
> +#ifdef ANDROID
> +     if (aFile == stdout) {
> +       // ADB logcat cut off long string so we will break it down

"cuts off long strings"

::: gfx/thebes/gfxASurface.h
@@ +5,5 @@
>  
>  #ifndef GFX_ASURFACE_H
>  #define GFX_ASURFACE_H
>  
> +#define MOZ_DUMP_IMAGES

Don't forget to remove this before landing!
Attachment #639163 - Flags: review?(ajuma) → review+
Attached patch patchSplinter Review
r=ajuma
Assignee: nobody → bgirard
Attachment #639163 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #639401 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/5e9b55369267
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.