771036 - Sanitizer.clearItem("history") not cleaning history

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

STR:
With a window as "window", execute:
let san = new window.Sanitizer();
san.clearItem("history");

Tested from within a menu button's handler code (window.NativeWindow.menu.add).

Expected:
History should be cleared.

Actual:
History is not cleared.

As the button-stuff in the preference menu works, I assume it is somewhere between gecko and the native ui causing the issue. The Sanitizers clean history method looks too short for me, as at least in desktop firefox the cleaning is done within the sanitizer, and not only a event broadcasted.
Sanitizer Code (mobile/android/chrome/content/sanitize.js):
try {
  Services.obs.notifyObservers(null, "browser:purge-session-history", "");
} catch (e) { }
// Clear last URL of the Open Web Location dialog
try {
  Services.prefs.clearUserPref("general.open_location.last_url");
} catch (e) { }

Comment 1

[Matt Brubeck (:mbrubeck)]

History is currently cleared by calling BrowserDB.clearHistory and GeckoApp.handleClearHistory in the Android Java code.  There's no way to clear it from JavaScript code (e.g. for an add-on).  We should fix this.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5d75d1a87f5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d5d75d1a87f5

Comment 5

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Thank you very much for that fast fix :)