2 strict warnings in test_constants.xul

RESOLVED FIXED in mozilla16

Status

()

Core
js-ctypes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: Yoric)

Tracking

Trunk
mozilla16
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1341473203.1341476269.12844.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/07/05 00:26:43
{
JavaScript strict warning: chrome://mochitests/content/chrome/dom/system/tests/test_constants.xul, line 62: anonymous function does not always return a value
JavaScript strict warning: chrome://mochitests/content/chrome/dom/system/tests/test_constants.xul, line 65: anonymous function does not always return a value
}
Created attachment 639278 [details] [diff] [review]
Fix warnings
Assignee: nobody → dteller
Attachment #639278 - Flags: review+
Thanks, fixing this.
Keywords: checkin-needed
(Reporter)

Comment 3

5 years ago
Comment on attachment 639278 [details] [diff] [review]
Fix warnings

Review of attachment 639278 [details] [diff] [review]:
-----------------------------------------------------------------

At first glance, this looks like what I expected.

Did you actually mean to self-review this?

::: dom/system/tests/test_constants.xul
@@ +48,2 @@
>    ok(true, "test_constants.xul: Chrome worker created");
>    worker.onerror = function(error) {

Nit: While here, could you give names to anonymous functions?

@@ +48,4 @@
>    ok(true, "test_constants.xul: Chrome worker created");
>    worker.onerror = function(error) {
>      error.preventDefault();
>      ok(false, "error "+error);

Nit: While here, could you add missing spaces around '+'s?
Attachment #639278 - Flags: feedback+
Created attachment 639286 [details] [diff] [review]
Fix warnings

Done. Thanks for the review and for spotting the warnings!
Attachment #639278 - Attachment is obsolete: true
Attachment #639286 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5a2135b072
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/bf5a2135b072
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.