771087 - 2 strict warnings in test_constants.xul

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1341473203.1341476269.12844.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/07/05 00:26:43
{
JavaScript strict warning: chrome://mochitests/content/chrome/dom/system/tests/test_constants.xul, line 62: anonymous function does not always return a value
JavaScript strict warning: chrome://mochitests/content/chrome/dom/system/tests/test_constants.xul, line 65: anonymous function does not always return a value
}

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Fix warnings

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Thanks, fixing this.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 639278 [details] [diff] [review]
Fix warnings

Review of attachment 639278 [details] [diff] [review]:
-----------------------------------------------------------------

At first glance, this looks like what I expected.

Did you actually mean to self-review this?

::: dom/system/tests/test_constants.xul
@@ +48,2 @@
>    ok(true, "test_constants.xul: Chrome worker created");
>    worker.onerror = function(error) {

Nit: While here, could you give names to anonymous functions?

@@ +48,4 @@
>    ok(true, "test_constants.xul: Chrome worker created");
>    worker.onerror = function(error) {
>      error.preventDefault();
>      ok(false, "error "+error);

Nit: While here, could you add missing spaces around '+'s?

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Fix warnings

Done. Thanks for the review and for spotting the warnings!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf5a2135b072

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/bf5a2135b072