771157 - IonMonkey: Crash [@ mozilla::DebugOnly<int>::operator++(int)]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase crashes on ionmonkey revision 9cf3ea112635 (run with --ion -n -m --ion-eager):


var callStack = new Array();
function TestCase(n, d, e, a) {
  this.expect = e;
  this.actual = a;
  this.passed = getTestCaseResult(e, a);
  dump(+ this.path + ' ' + 'reason: ' + toPrinted(this.reason)+ '\n');
};
function reportCompare (expected, actual, description) {
  var testcase = new TestCase("unknown-test-name", description, expected, actual);
}
function enterFunc (funcName) {
  callStack.push(funcName);
  var lastFunc = callStack.pop();
  reportCompare(funcName, lastFunc, "Test driver failure wrong exit function ");
}
try {
var summary = 'String static methods';
var actual = '';
expect = '2';
reportCompare(expect, actual, summary + " String.toUpperCase(new Boolean(true))");
} catch(exc0) {}
try {
function TestCase(n, d, e, a) {}
enterFunc ('test');
reportCompare(expect, actual, summary);
} catch(exc2) {}

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Kannan, this looks like fallout from polymorphic inlining: we assert adding MIR to a block that has ended. lastIns = InlineFunctionGuard and the MIR we're adding is a CreateThis.

Comment 2

[Kannan Vijayan [:djvj]]

Attachment: Refactoring to resolve bug.

This cleans up the sequencing of blocks in the poly inline code.

I also removed some asserts that seem really unnecessary.

Comment 3

[Kannan Vijayan [:djvj]]

https://hg.mozilla.org/projects/ionmonkey/rev/5d1b1af768fc

Comment 4

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/2e891e0db397