771201 - Characters committed at every typing on fullscreen keyboard

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect, P3)

Description

[Jinkyu Yi[:jincreator]]

1. Open any site and tap text field to write.
2. Change keyboared to CJK keyboard.
3. Change it to fullscreen typing. On most virtual keyboard, rotate phone to landscape will do it.
4. Start typing.

The characters are committed on every type.

Korean ex)ㄱ+ㅏ -> ㄱㅏ (two letters)
Japanese ex)あくえお　-> あいうえお (not underlined)

Characters should commit when one(or more) letter(s) completed. If you can't understand what it means, type anything at portrait mode and compare it.


Korean ex)ㄱ+ㅏ -> 가 (one letter with underlined)
Japanese ex)あいうえお -> あいうえお (underlined with suggestion list)

*I tested with Nexus S ICS((4.0.4) and Google Chinese, Japanese, Korean keyboard. Google keyboards can be downloaded through Google Play(a.k.a Andorid Market).

Comment 1

[Jinkyu Yi[:jincreator]]

Attachment: fullscreen typing problem

Type '가' at fullscreen keyboard.
Notice ㄱ and ㅏ are committed seperately, not one letter '가'.

Comment 2

[Jinkyu Yi[:jincreator]]

Attachment: normal typing - work as expected

Type '가' at normal mode.
The letter is not completed, so it's underlined.
Also suggestion area is showing similar words.

Comment 3

[Makoto Kato [:m_kato]]

confirmed with latest

Comment 4

[Makoto Kato [:m_kato]]

Maybe, this doesn't occurs on XUL version.  Although  GeckoInputConnection.notifySelectionChange calls imm.updateSelection, this call is invalid...

Comment 5

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 646942 [details] [diff] [review]
fix

This is regression by Native UI.  On XUL version, we don't set -1 to updateSelection during composing.

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 646942 [details] [diff] [review]
fix

Review of attachment 646942 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!

Comment 8

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/493da08175ec

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/493da08175ec