771242 - "Assertion failure: flags_ & HAS_ARGS_OBJ,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

a = function() {
  b = newGlobal()
};
c = [0, 0]
c.sort(a)
function d() {
  yield arguments[4]
}
b.iterate = d
f = Proxy.create(b)
e = Iterator(f, true)
for (p in f) {
  e.next()
}

asserts js debug shell on m-c changeset e0f64c714814 without any CLI arguments at Assertion failure: flags_ & HAS_ARGS_OBJ,

Valgrind does not indicate anything bad on opt.

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   97976:d4ac6ac2e618
user:        Luke Wagner
date:        Thu Jun 28 22:50:15 2012 -0700
summary:     Bug 767667 - fix getelem on optimized arguments (r=bhackett)

Comment 1

[Luke Wagner [:luke]]

Attachment: patch and test

Oh duh, generators can be suspended when argumentsOptimizationFailed.  The patch just disables the arguments optimization for generators; fixing it would involve hunting down all generators in the heap.

Comment 2

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/007003bb82c9

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/007003bb82c9

Comment 4

[Christian Holler (:decoder)]

A testcase for this bug was automatically identified at js/src/jit-test/tests/basic/testBug771242.js.