771248 - Enable WebRTC in builds by default (except for Android/B2G)

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Flip webrtc to be built by default (except Android/B2G)

This is in preparation for landing getUserMedia (bug 691234); I want to shake out any build issues (especially on the wide selection of developer's systems; it works on Try) before landing navigator.mozGetUserMedia().

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Flip webrtc build pref to on

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Try without code to disable for ANdroid & B2G:
https://tbpl.mozilla.org/?tree=Try&rev=36739e0635df
(Note: talos reds, build purple are due to hg/etc infrastructure failure during the run.)

Try of patch with webrtc disabled for Android/B2G:
https://tbpl.mozilla.org/?tree=Try&rev=0c8116c581a9

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 639457 [details] [diff] [review]
Flip webrtc build pref to on

Time to flip the pref for webrtc in preparation for landing getUserMedia (up for review now).  Warning was given to people in the Platform weekly meeting and notes.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 639457 [details] [diff] [review]
Flip webrtc build pref to on

Review of attachment 639457 [details] [diff] [review]:
-----------------------------------------------------------------

Don't you need to switch the configure option to --disable-webrtc?

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Flip webrtc build pref to on

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 639589 [details] [diff] [review]
Flip webrtc build pref to on

Flip pref name to match new default (--disable-webrtc works in either case, and it defaults to on either way, but this gives the correct impression of the default if you do configure --help)

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2538f744029c

Comment 8

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Backed out for failing PGO builds the exact same way it did when you pushed it to try.

http://hg.mozilla.org/integration/mozilla-inbound/rev/fec28c1afb63

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

This bounce was because of bug 771588, which we had no reason to believe would show up without PGO being turned on for libvpx.  (We ran across the bug with PGO on when trying to merge gkmedia back into libxul when doing tests for bug 768325, and the bug went away with PGO off, so we didn't think there was any reason to anticipate a problem with the landing.)

My trys last night were ok (modulo infrastructure failure), but being normal trys didn't run PGO builds.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Flip webrtc build pref to on and disable PGO for libvpx offset generation

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Try (still) running at https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 639824 [details] [diff] [review]
Flip webrtc build pref to on and disable PGO for libvpx offset generation

asking any build peer for review... (on the assumption the try goes ok - it's running with PGO)

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Flip webrtc build pref to on

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

libvpx changes are now in patch on bug 771588

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f86b9868abd9

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f86b9868abd9