Fix comment about FASTCALL and inline functions

RESOLVED FIXED

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 639452 [details] [diff] [review]
Fix comment about FASTCALL and inline functions

Calling convention does not make a difference on functions that are inlined, but that feels obvious because no call is being made. Inline functions are not necessarily inlined so this comment is somewhat misleading.
Attachment #639452 - Flags: review?(respindola)
Comment on attachment 639452 [details] [diff] [review]
Fix comment about FASTCALL and inline functions

Review of attachment 639452 [details] [diff] [review]:
-----------------------------------------------------------------

I just tested and both clang and gcc apply to regparm attribute to an inline function that is not inlined.
Attachment #639452 - Flags: review?(respindola) → review+
This was fixed in git's e8160e9af955ef8b65e5499b9b209490b3818ed8.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.