Closed
Bug 771317
Opened 13 years ago
Closed 13 years ago
Fix comment about FASTCALL and inline functions
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(1 file)
|
811 bytes,
patch
|
espindola
:
review+
|
Details | Diff | Splinter Review |
Calling convention does not make a difference on functions that are inlined, but that feels obvious because no call is being made. Inline functions are not necessarily inlined so this comment is somewhat misleading.
Attachment #639452 -
Flags: review?(respindola)
Comment on attachment 639452 [details] [diff] [review]
Fix comment about FASTCALL and inline functions
Review of attachment 639452 [details] [diff] [review]:
-----------------------------------------------------------------
I just tested and both clang and gcc apply to regparm attribute to an inline function that is not inlined.
Attachment #639452 -
Flags: review?(respindola) → review+
This was fixed in git's e8160e9af955ef8b65e5499b9b209490b3818ed8.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•