disallow plugins in popup panels gracefully

RESOLVED FIXED in mozilla16

Status

()

Core
Layout: Misc Code
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 639485 [details] [diff] [review]
patch

Some nsObjectFrame code was assuming that mInnerView existed if mWidget was non-null.

I thought about nulling out mWidget if we hit a failure case but we use null mWidget to indicate a windowless plugin elsewhere. So I went with mWidget and mInnerView existing to indicate an error-free windowed plugin.

I looked at all the users of nsObjectFrame::GetWidget, they were
http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp?rev=c35d2d3071ac#1731
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#879
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#969
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#2116

and I think they should all get a null widget if we hit a failure case (except for the one I changed in this patch). I also looked at all uses of mWidget and guarded them as needed
Attachment #639485 - Flags: review?(roc)
Attachment #639485 - Flags: review?(roc) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/10483a67fe11
https://hg.mozilla.org/mozilla-central/rev/10483a67fe11
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.