Last Comment Bug 771351 - disallow plugins in popup panels gracefully
: disallow plugins in popup panels gracefully
Product: Core
Classification: Components
Component: Layout: Misc Code (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Timothy Nikkel (:tnikkel)
: Jet Villegas (:jet)
Depends on:
  Show dependency treegraph
Reported: 2012-07-05 15:03 PDT by Timothy Nikkel (:tnikkel)
Modified: 2012-07-06 07:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (4.85 KB, patch)
2012-07-05 15:12 PDT, Timothy Nikkel (:tnikkel)
roc: review+
Details | Diff | Splinter Review

Description Timothy Nikkel (:tnikkel) 2012-07-05 15:03:43 PDT

Comment 1 Timothy Nikkel (:tnikkel) 2012-07-05 15:12:00 PDT
Created attachment 639485 [details] [diff] [review]

Some nsObjectFrame code was assuming that mInnerView existed if mWidget was non-null.

I thought about nulling out mWidget if we hit a failure case but we use null mWidget to indicate a windowless plugin elsewhere. So I went with mWidget and mInnerView existing to indicate an error-free windowed plugin.

I looked at all the users of nsObjectFrame::GetWidget, they were

and I think they should all get a null widget if we hit a failure case (except for the one I changed in this patch). I also looked at all uses of mWidget and guarded them as needed
Comment 2 Timothy Nikkel (:tnikkel) 2012-07-05 17:46:01 PDT

Note You need to log in before you can comment on or make changes to this bug.