771351 - disallow plugins in popup panels gracefully

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Some nsObjectFrame code was assuming that mInnerView existed if mWidget was non-null.

I thought about nulling out mWidget if we hit a failure case but we use null mWidget to indicate a windowless plugin elsewhere. So I went with mWidget and mInnerView existing to indicate an error-free windowed plugin.

I looked at all the users of nsObjectFrame::GetWidget, they were
http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp?rev=c35d2d3071ac#1731
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#879
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#969
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#2116

and I think they should all get a null widget if we hit a failure case (except for the one I changed in this patch). I also looked at all uses of mWidget and guarded them as needed

Comment 2

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10483a67fe11

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/10483a67fe11