Closed Bug 771351 Opened 8 years ago Closed 8 years ago
disallow plugins in popup panels gracefully
No description provided.
Some nsObjectFrame code was assuming that mInnerView existed if mWidget was non-null. I thought about nulling out mWidget if we hit a failure case but we use null mWidget to indicate a windowless plugin elsewhere. So I went with mWidget and mInnerView existing to indicate an error-free windowed plugin. I looked at all the users of nsObjectFrame::GetWidget, they were http://mxr.mozilla.org/mozilla-central/source/dom/base/nsFocusManager.cpp?rev=c35d2d3071ac#1731 http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsContentEventHandler.cpp#879 http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#969 http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsObjectFrame.cpp?rev=f08886a8cf22#2116 and I think they should all get a null widget if we hit a failure case (except for the one I changed in this patch). I also looked at all uses of mWidget and guarded them as needed
Attachment #639485 - Flags: review?(roc)
Attachment #639485 - Flags: review?(roc) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.