Created attachment 639485 [details] [diff] [review]
Some nsObjectFrame code was assuming that mInnerView existed if mWidget was non-null.
I thought about nulling out mWidget if we hit a failure case but we use null mWidget to indicate a windowless plugin elsewhere. So I went with mWidget and mInnerView existing to indicate an error-free windowed plugin.
I looked at all the users of nsObjectFrame::GetWidget, they were
and I think they should all get a null widget if we hit a failure case (except for the one I changed in this patch). I also looked at all uses of mWidget and guarded them as needed