771421 - Stop running browser-chrome on Android XUL on every branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: configs v1

The way I hear it, we have absolutely no intention of ever releasing any Android XUL build on any branch ever again. The only reason we haven't just dumped it completely is because b2g wants to have the mochitests to make sure OOP mochitests don't break before they can get their own version running.

Because browser-chrome is specifically testing the browser that we're never going to release again, it makes a particularly nice camel's nose to get inside the tent - there's just no possible reason to keep running it.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 639584 [details] [diff] [review]
configs v1

I am OK with this change.

Comment 2

[Armen [:armenzg]]

Comment on attachment 639584 [details] [diff] [review]
configs v1

Because I love these patches:
http://hg.mozilla.org/build/buildbot-configs/rev/212f76f4df27

Thanks philor!

Comment 3

[Armen [:armenzg]]

Comment on attachment 639584 [details] [diff] [review]
configs v1

This does not pass ./test-masters.sh

Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/buildbot-0.8.2_hg_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_d8998b10d0b6_default-py2.7.egg/buildbot/scripts/runner.py", line 1039, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/Library/Python/2.7/site-packages/buildbot-0.8.2_hg_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_d8998b10d0b6_default-py2.7.egg/buildbot/scripts/checkconfig.py", line 31, in __init__ 
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/Library/Python/2.7/site-packages/buildbot-0.8.2_hg_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_Not_trusting_file_Users_armenzg_repos_releng_buildbot_.hg_hgrc_from_untrusted_user_armenzg_group_staff_d8998b10d0b6_default-py2.7.egg/buildbot/master.py", line 628, in loadConfig
    exec f in localDict
  File "/Users/armenzg/repos/buildbot-configs/test-output/bm17-tests1-linux-qL4x2e/master.cfg", line 99, in <module>
    BRANCH_UNITTEST_VARS['platforms'])
  File "/Users/armenzg/repos/buildbotcustom/misc.py", line 3256, in generateTalosBranchObjects
    for suites_name, suites in branch_config['platforms'][platform][slave_platform][unittest_suites]:
KeyError: 'mobile_unittest_suites'

Comment 4

[Phil Ringnalda (:philor)]

Attachment: configs v2

Does this work? I apparently don't know how to run test-masters.sh, since it just errors out and creates a bunch of zero byte logs even without a patch, but if this kills running browser-chrome, I'd be happy to leave cleaning up that unused stuff (which now looks suspiciously like someone left it for this very reason) to someone else.

Comment 5

[Justin Wood (:Callek)]

armen, didn't we say we couldn't disable tests for Android XUL until win8 was being tested? (I admit aurora/beta/release/esr can probably be turned off though)

Comment 6

[Phil Ringnalda (:philor)]

Maybe we could switch it to running zero tests? Nobody who would say that they had to have Android XUL browser-chrome running for any reason has ever looked at it, they wouldn't notice the difference.

Comment 7

[Aki Sasaki (not active)]

Currently seeing a lot of backlog on android tests, a la bug 772458.

Comment 8

[Aki Sasaki (not active)]

Reopening per bug 771756 comment 7.

Comment 9

[Aki Sasaki (not active)]

Attachment: no android-xul browser-chrome

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 640876 [details] [diff] [review]
no android-xul browser-chrome

http://hg.mozilla.org/build/buildbot-configs/rev/7070984d5ffb

Comment 11

[Aki Sasaki (not active)]

This made it to production today.