771466 - GCLI devtools.command.dir option should accept ~ for home directory

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P3)

Comment 1

[Joe Walker [:jwalker]]

Triage: Filter on the TRIAGE keyword.

Comment 2

[SADINENI RAVI CHANDRA]

like to work on this bug....

Comment 3

[SADINENI RAVI CHANDRA]

can u suggest me where to start ??

Comment 4

[Joe Walker [:jwalker]]

The code that processes the command dir is in browser/devtools/commandline/CmdCmd.jsm see refreshAutoCommands().

We need to check for an initial ~/ and replace with the users home directory, which we can probably get as using the docs here:
https://developer.mozilla.org/en-US/docs/Code_snippets/File_I_O#Getting_special_files

Hope that helps.

Comment 5

[SADINENI RAVI CHANDRA]

Attachment: it resolves ~/file /home/path/file and simillarly in windows

now it works as expected

Comment 6

[Joe Walker [:jwalker]]

Comment on attachment 656520 [details] [diff] [review]
it resolves ~/file /home/path/file and simillarly in windows

Review of attachment 656520 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/commandline/CmdCmd.jsm
@@ +67,5 @@
> +        let homeDirFile = dirService.get("Home", Ci.nsIFile); // returns an nsIFile object
> +        let homeDir = homeDirFile.path; 	
> +        dirName =  dirName.substr(2);
> +        dirName = homeDir + "\\" + dirName;    
> +    }

Thanks for this.
I think there is some tidying up that we can do. We generally use 2 space tabs in mozilla, and we remove spaces at the end of lines.

Also the first 4 lines of these if statements are the same. How about checking for an initial '~', then calculating the homeDir and removing the first character of the dirName before prefixing with the homeDir?

Comment 7

[SADINENI RAVI CHANDRA]

ya you are right .... i will make the changes.....

Comment 8

[SADINENI RAVI CHANDRA]

Attachment: made the required changes

Comment 9

[Joe Walker [:jwalker]]

Comment on attachment 656589 [details] [diff] [review]
made the required changes

Review of attachment 656589 [details] [diff] [review]:
-----------------------------------------------------------------

There are still a few spaces out, but I can tweak that as I land.
Thanks.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Found this during a bug search, appears to be a reviewed patch that needs landing.

Comment 11

[Joe Walker [:jwalker]]

Thanks Rob. Added to my landing list.

Comment 12

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 13

[Joe Walker [:jwalker]]

Attachment: v2

Rebased.
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=3425b0ead8cb

Comment 14

[Joe Walker [:jwalker]]

And sorry for the delay in getting this landed!

Comment 15

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=f952eebd4cbd
https://hg.mozilla.org/integration/fx-team/rev/6a1a959b8a2c

Comment 16

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/6a1a959b8a2c