771484 - If the searched string doesn't match anything when filtering scripts with "#", the search is done by the first N chars of the string that do have a match

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P3)

Description

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120705 Firefox/15.0a2 (20120705042010)

STR:
1. Load a web page with multiple scripts in the browser.
2. Open the Debugger.
3. Enter a string in the "Filter scripts" textbox as follows: filename#str. Make sure the str string doesn't match any of the strings in the filename script.

If the searched string doesn't match anything when filtering scripts with "#", the search is done by the first N chars of the string that do have a match. For example, if I used "filename#whasdasd" for filtering, "while" was displayed as a match.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Victor, is that a result of us not clearing the previous matches as the user types more characters?

Comment 2

[Victor Porof [:vporof][:vp]]

(In reply to Panos Astithas [:past] from comment #1)
> Victor, is that a result of us not clearing the previous matches as the user
> types more characters?

Yes. I thought of this as a feature.
The more conservative way of doing this is 'jump to the first line of the file and deselect anything that was already selected/found'. Do we want this? Yes, it should be an easy fix, and I guess the win is not confusing the users, however some people prefer their searches to be as fuzzy as they can.

Panos, what do you think?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Victor Porof from comment #2)
> (In reply to Panos Astithas [:past] from comment #1)
> > Victor, is that a result of us not clearing the previous matches as the user
> > types more characters?
> 
> Yes. I thought of this as a feature.
> The more conservative way of doing this is 'jump to the first line of the
> file and deselect anything that was already selected/found'. Do we want
> this? Yes, it should be an easy fix, and I guess the win is not confusing
> the users, however some people prefer their searches to be as fuzzy as they
> can.
> 
> Panos, what do you think?

Hm, I see your point. And we already highlight the matching characters, so it's not too unintuitive. If Ron agrees, I'd say we should WONTFIX this.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Panos Astithas [:past] from comment #3)
> (In reply to Victor Porof from comment #2)
> > (In reply to Panos Astithas [:past] from comment #1)
> > > Victor, is that a result of us not clearing the previous matches as the user
> > > types more characters?
> > 
> > Yes. I thought of this as a feature.
> > The more conservative way of doing this is 'jump to the first line of the
> > file and deselect anything that was already selected/found'. Do we want
> > this? Yes, it should be an easy fix, and I guess the win is not confusing
> > the users, however some people prefer their searches to be as fuzzy as they
> > can.
> > 
> > Panos, what do you think?
> 
> Hm, I see your point. And we already highlight the matching characters, so
> it's not too unintuitive. If Ron agrees, I'd say we should WONTFIX this.

And besides Ron's, I'd also like Rob's thoughts on this.